From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FFCDC4727E for ; Thu, 24 Sep 2020 19:38:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E6AC22220C for ; Thu, 24 Sep 2020 19:38:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726200AbgIXTin (ORCPT ); Thu, 24 Sep 2020 15:38:43 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:43825 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725272AbgIXTin (ORCPT ); Thu, 24 Sep 2020 15:38:43 -0400 X-Greylist: delayed 40034 seconds by postgrey-1.27 at vger.kernel.org; Thu, 24 Sep 2020 15:38:42 EDT Received: from mail-qv1-f47.google.com ([209.85.219.47]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MxVbb-1kfODR2rKz-00xvac; Thu, 24 Sep 2020 21:38:40 +0200 Received: by mail-qv1-f47.google.com with SMTP id ef16so122056qvb.8; Thu, 24 Sep 2020 12:38:40 -0700 (PDT) X-Gm-Message-State: AOAM531kDPXkhiZYw7gvR8oXc2heYsLvEpV9mIKBjCPto49n89+ceUsI l8ZvAVFamL2KGyu/TPyXdkbklxkhLbil8skWJ34= X-Google-Smtp-Source: ABdhPJwb2a07lzpQCrzg3jtFtJXS1gTYpcGBk/RGooNlixhivRVF08OHCGO55og0kHNqshgFEi2ogMfqzGxcRooZPQk= X-Received: by 2002:a05:6214:1873:: with SMTP id eh19mr870293qvb.16.1600976319259; Thu, 24 Sep 2020 12:38:39 -0700 (PDT) MIME-Version: 1.0 References: <20200923151511.3842150-1-luzmaximilian@gmail.com> In-Reply-To: From: Arnd Bergmann Date: Thu, 24 Sep 2020 21:38:23 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 0/9] Add support for Microsoft Surface System Aggregator Module To: Maximilian Luz Cc: "linux-kernel@vger.kernel.org" , linux-serial@vger.kernel.org, ACPI Devel Maling List , Greg Kroah-Hartman , Rob Herring , Jiri Slaby , "Rafael J. Wysocki" , Len Brown , =?UTF-8?Q?Bla=C5=BE_Hrastnik?= , Dorian Stoll , Darren Hart , Andy Shevchenko , Platform Driver Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:3BIMiRbgQycvNucXKzcS5vkFqPEIq3DE+mg6SzlMWwm40f+ulB+ Nrj3ZhQEPewWAlItOhTfoo6fJX2dZNuRXreOKr256QJ+TZXb8DXiUB3zyEzbCQcjrG8bpA5 BpR0XJhxNl3gNe2MHCJV8KFKSNqujJy/XM7wNUmXctOkn0E/zBMS9jIblaXJuyM3qKWq51V Os3pkhdAqZXrcikTGLZ8g== X-UI-Out-Filterresults: notjunk:1;V03:K0:OLGtHSwCH/k=:V51WjINOskBmYYiF4aUWtl 0nkM1XPgkorf7lcmMX+SQrvSi2HzsJXLxHs2Ebs5iiuGtV0fbXtWaNhBlvUvoMAjctODVDf7T UJHRxgf80Gk+q8EssMsT5OgX7VxP6/1EApjda+uTC5i35PA9gOPEaU6A2/+bII4K5P77apX6i OiTUxcJ4Du3CXJrZceOnE5+GgZS50B7RdTAQjd2Tohi9le8kcjdQcXqLMGwdN2fw/ULJmYPB1 X6L5wucGA5RukUe7V/sOSJbXcPWdKW+rVi0FVDvHbkuBLtnyceKKyBF9/ZoIx/qn2h/6ygHMm fCjlXh7lgKZEB5OyXooEsHMjgDivugwdKORiSwQ1oArJhmCKbq1qT5CZK53qYSfBsQguPSaBI Z7dlDwDYYjP8+g1/vtT/t8bY1u2pKIUyeaG1jXYC89gfRc/ou8mbZYGQpZMd5yZuPes3KY2Bw JJfK0T2KSXC1SEVzILjwgyeOuhljg0VjXYFgWSgmmEJDrvcKTadd8XcwpOcvQKNQKT7WTBTr3 FPuD1MxZnmBTZwpA2QilhTwJcZFAmbuRxFeFI4+5atuc5Ra5qB1OXzVcSyo0b1UfneAHrqBI5 yXrmAYMSVtVTyzjnt4wrVhYu3Tj6Sj10XttrXK8Ml9nY4x9Ev/LyD15TX3nO7tfsPElmYUTph YDj5vKdnoYeDmqpy3Ddbv16sjDn6443xXq9mkWjd/AX4V2mm6CF4H6Qx0YvVbATbTrSSCXe6R rhJV0uTzjmSpPKFR+AhOA+QyDjoE5TzsTei2hV+FUFtQEw1xu932/E2/O0MZuvRWkUVsivVhK WNQ9ls/8lQwFPvuJPu76XNw0cDCCgFb4B2M6EHeZ4IaN6tjEVtOSN5dC3ou432nfaYOqx21 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 24, 2020 at 8:59 PM Maximilian Luz wrote: > On 9/24/20 10:26 AM, Arnd Bergmann wrote: > > On Thu, Sep 24, 2020 at 1:28 AM Maximilian Luz wrote: > > Note that drivers that connect to the bus typically don't live in the > > same subdirectory as the driver that operates the bus. E.g. the > > battery driver would go into drivers/power/supply and the input > > would go into drivers/input/ or drivers/hid. > > Right. I wonder if this also holds for devices that are directly > dependent on a special platform though? It could make sense to have them > under plaform/surface rather than in the individual subsystems as they > are only ever going to be used on this platform. On the other hand, one > could argue that having them in the subsystem directories is better for > maintainability. Yes, absolutely. The subsystem maintainers are the ones that are most qualified of reviewing code that uses their subsystem, regardless of which bus is used underneath the device, and having all drivers for a subsystem in one place makes it much easier to refactor them all at once in case the internal interfaces are changed or common bugs are found in multiple drivers. Arnd