From: Arnd Bergmann <arnd@kernel.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Maxim Levitsky <maximlevitsky@gmail.com>,
Alex Dubov <oakad@yahoo.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Nathan Chancellor <nathan@kernel.org>,
Jing Xiangfeng <jingxiangfeng@huawei.com>,
Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>
Subject: Re: [PATCH] memstick: r592: ignore kfifo_out() return code again
Date: Wed, 21 Apr 2021 21:27:46 +0200 [thread overview]
Message-ID: <CAK8P3a23w+8Hzj0v7c32ebH1Qj0xE3+uO+WUsmnLUM3QXfyV1A@mail.gmail.com> (raw)
In-Reply-To: <CAKwvOdk21V0qW_xQrWqQYnrw8nEr_+KTJnVZgL0gJsJiUf2Scw@mail.gmail.com>
On Wed, Apr 21, 2021 at 7:17 PM 'Nick Desaulniers' via Clang Built
Linux <clang-built-linux@googlegroups.com> wrote:
> On Wed, Apr 21, 2021 at 6:52 AM Arnd Bergmann <arnd@kernel.org> wrote:
> > The value was never checked here, and the purpose of the function
> > is only to flush the contents, so restore the old behavior but
> > add a cast to void and a comment, which hopefully warns with neither
> > gcc nor clang now.
> >
> > If anyone has an idea for how to fix it without ignoring the return
> > code, that is probably better.
>
> Should r592_flush_fifo_write be made to return an int, then callers of
> r592_flush_fifo_write percolate up their return code?
> r592_transfer_fifo_pio() seems to only return 0, but its callers are
> doing return code checking.
I looked into that but couldn't come up with anything useful to do with
the return code in the callers. kfifo_out() itself doesn't seem to
ever return an error but only the length.
Arnd
next prev parent reply other threads:[~2021-04-21 19:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 13:51 [PATCH] memstick: r592: ignore kfifo_out() return code again Arnd Bergmann
2021-04-21 17:16 ` Nick Desaulniers
2021-04-21 19:27 ` Arnd Bergmann [this message]
2021-04-23 7:59 ` Ulf Hansson
2021-04-26 9:44 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a23w+8Hzj0v7c32ebH1Qj0xE3+uO+WUsmnLUM3QXfyV1A@mail.gmail.com \
--to=arnd@kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=jingxiangfeng@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=oakad@yahoo.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).