From: Arnd Bergmann <arnd@arndb.de>
To: "Winkler, Tomas" <tomas.winkler@intel.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Jerry Snitselaar <jsnitsel@redhat.com>,
"tpmdd-devel@lists.sourceforge.net"
<tpmdd-devel@lists.sourceforge.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tpm/tpm_crb: mark PM functions as __maybe_unused
Date: Mon, 20 Mar 2017 13:27:32 +0100 [thread overview]
Message-ID: <CAK8P3a25sh0U=N9E1pWACL_9h7VBseUBX50WZe5rXMpNHY=GbA@mail.gmail.com> (raw)
In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B543B032E@hasmsx108.ger.corp.intel.com>
On Mon, Mar 20, 2017 at 1:11 PM, Winkler, Tomas <tomas.winkler@intel.com> wrote:
>>
>> When CONFIG_PM_SLEEP is disabled, we get a warning about unused
>> functions:
>>
>> drivers/char/tpm/tpm_crb.c:551:12: error: 'crb_pm_resume' defined but not
>> used [-Werror=unused-function]
>> drivers/char/tpm/tpm_crb.c:540:12: error: 'crb_pm_suspend' defined but not
>> used [-Werror=unused-function]
>>
> Note that the runtime_pm functions are not affected by this issue the macro
> SET_RUNTIME_PM_OPS is under CONFIG_PM. This patch does more than described.
Well, the problem is that there is an #ifdef that is wrong here as I
tried to indicate:
>> We could solve this with more sophistated #ifdefs, but a simpler and safer way
>> is to just mark them as __maybe_unused.
>> @@ -547,7 +546,7 @@ static int crb_pm_suspend(struct device *dev)
>> return crb_pm_runtime_suspend(dev);
>> }
>
> It's enough to
> #endif /* CONFIG_PM */
> #ifdef CONFIG_PM_SLEEP
>> -static int crb_pm_resume(struct device *dev)
>> +static __maybe_unused int crb_pm_resume(struct device *dev)
>> {
>> int ret;
>>
>> @@ -558,8 +557,6 @@ static int crb_pm_resume(struct device *dev)
>> return tpm_pm_resume(dev);
>> }
>>
>> -#endif /* CONFIG_PM */
> And
> #endif CONFIG_PM_SLEEP
This tends to cause other warnings half of the time, when both the
runtime-pm and pm-sleep variants call into another function that
becomes unused when both are disabled.
Arnd
next prev parent reply other threads:[~2017-03-20 12:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 9:17 [PATCH] tpm/tpm_crb: mark PM functions as __maybe_unused Arnd Bergmann
2017-03-20 12:11 ` Winkler, Tomas
2017-03-20 12:27 ` Arnd Bergmann [this message]
2017-03-20 23:01 ` Winkler, Tomas
2017-03-20 23:04 ` Jason Gunthorpe
2017-03-20 23:35 ` Winkler, Tomas
2017-03-21 7:37 ` Arnd Bergmann
2017-03-22 10:21 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a25sh0U=N9E1pWACL_9h7VBseUBX50WZe5rXMpNHY=GbA@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=jsnitsel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tomas.winkler@intel.com \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).