From: Arnd Bergmann <arnd@arndb.de>
To: Brad Larson <brad@pensando.io>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Arnd Bergmann <arnd@arndb.de>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Mark Brown <broonie@kernel.org>,
Serge Semin <fancer.lancer@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Olof Johansson <olof@lixom.net>, David Clear <dac2@pensando.io>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
DTML <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 09/11] mmc: sdhci-cadence: Add Pensando Elba SoC support
Date: Thu, 7 Apr 2022 22:38:31 +0200 [thread overview]
Message-ID: <CAK8P3a28ef+DgcKrMG03b5Og-W+afieoqF1zvNkXdG22qA8i7g@mail.gmail.com> (raw)
In-Reply-To: <CAK9rFnwsMd1+oQ8cg8Biw7HM=R6aOudfK7Ja+E+iGVgfrvC9Gg@mail.gmail.com>
On Thu, Apr 7, 2022 at 7:06 PM Brad Larson <brad@pensando.io> wrote:
> On Thu, Apr 7, 2022 at 12:13 AM Adrian Hunter <adrian.hunter@intel.com> wrote:
> >
> > What is the relationship between cadence and pensando elba?
>
> Pensando licensed the cadence controller, its 100% cadence IP. The
> integration issue we ran into was with the accessors where we have the
> workaround. The initial patch added a separate Elba driver file but
> the feedback was the Elba support didn't justify doing that and to add
> to sdhci-cacence.c.
I looked back at the earlier reviews now, I think the main problem with
versions 1 and 2 was that it had the abstraction the wrong way around,
so you added the complexity of having multiple files, without the benefits.
I still think that the cleanest approach would be to have it the way I
suggested in my reply to v1, with an elba specific platform driver
that calls into the generic cadence code, but the generic code knowing
nothing about the front-end.
Then again, it sounds like there was already an agreement about
the approach you took here, so let's stay with that and hope we don't
get any other chips with the same IP block in the future.
Arnd
next prev parent reply other threads:[~2022-04-07 20:49 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 23:36 [PATCH 00/11] Support Pensando Elba SoC Brad Larson
2022-04-06 23:36 ` [PATCH 01/11] dt-bindings: arm: add Pensando boards Brad Larson
2022-04-07 18:45 ` Krzysztof Kozlowski
2022-04-09 2:19 ` Brad Larson
2022-04-09 10:39 ` Krzysztof Kozlowski
2022-04-11 21:24 ` Serge Semin
2022-05-25 16:31 ` Brad Larson
2022-04-07 18:54 ` Krzysztof Kozlowski
2022-04-09 2:04 ` Brad Larson
2022-04-06 23:36 ` [PATCH 02/11] dt-bindings: Add vendor prefix for Pensando Systems Brad Larson
2022-04-07 18:43 ` Krzysztof Kozlowski
2022-04-09 2:00 ` Brad Larson
2022-04-06 23:36 ` [PATCH 03/11] dt-bindings: mmc: Add Pensando Elba SoC binding Brad Larson
2022-04-07 6:30 ` Arnd Bergmann
2022-05-25 15:46 ` Brad Larson
2022-04-07 18:57 ` Krzysztof Kozlowski
2022-05-25 15:49 ` Brad Larson
2022-04-06 23:36 ` [PATCH 04/11] dt-bindings: spi: Add compatible for Pensando Elba SoC Brad Larson
2022-04-07 18:59 ` Krzysztof Kozlowski
2022-05-25 16:58 ` Brad Larson
2022-04-12 11:37 ` Serge Semin
2022-05-25 17:03 ` Brad Larson
2022-04-06 23:36 ` [PATCH 05/11] dt-bindings: spi: dw: Add Pensando Elba SoC SPI Controller bindings Brad Larson
2022-04-07 18:52 ` Krzysztof Kozlowski
2022-04-11 21:17 ` Serge Semin
2022-05-26 0:27 ` Brad Larson
2022-04-12 11:29 ` Serge Semin
2022-04-06 23:36 ` [PATCH 06/11] MAINTAINERS: Add entry for PENSANDO Brad Larson
2022-04-06 23:36 ` [PATCH 07/11] arm64: Add config for Pensando SoC platforms Brad Larson
2022-04-06 23:36 ` [PATCH 08/11] spi: cadence-quadspi: Add compatible for Pensando Elba SoC Brad Larson
2022-04-06 23:36 ` [PATCH 09/11] mmc: sdhci-cadence: Add Pensando Elba SoC support Brad Larson
2022-04-07 6:45 ` Arnd Bergmann
2022-04-07 7:13 ` Adrian Hunter
2022-04-07 17:06 ` Brad Larson
2022-04-07 20:38 ` Arnd Bergmann [this message]
2022-05-25 16:10 ` Brad Larson
2022-04-06 23:36 ` [PATCH 10/11] spi: dw: Add support for Pensando Elba SoC Brad Larson
2022-04-12 11:06 ` Serge Semin
2022-05-25 21:54 ` Brad Larson
2022-04-06 23:36 ` [PATCH 11/11] arm64: dts: Add Pensando Elba SoC support Brad Larson
2022-04-07 7:57 ` Marc Zyngier
2022-04-09 2:38 ` Brad Larson
2022-04-09 9:18 ` Marc Zyngier
2022-05-25 17:28 ` Brad Larson
2022-04-07 19:06 ` Krzysztof Kozlowski
2022-05-26 0:19 ` Brad Larson
2022-05-26 6:53 ` Krzysztof Kozlowski
2022-04-07 20:58 ` Krzysztof Kozlowski
2022-04-12 11:22 ` Serge Semin
2022-05-25 20:06 ` Brad Larson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a28ef+DgcKrMG03b5Og-W+afieoqF1zvNkXdG22qA8i7g@mail.gmail.com \
--to=arnd@arndb.de \
--cc=adrian.hunter@intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=brad@pensando.io \
--cc=broonie@kernel.org \
--cc=dac2@pensando.io \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=olof@lixom.net \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).