From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753297AbdCAWnK (ORCPT ); Wed, 1 Mar 2017 17:43:10 -0500 Received: from mail-ot0-f193.google.com ([74.125.82.193]:34275 "EHLO mail-ot0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750947AbdCAWnI (ORCPT ); Wed, 1 Mar 2017 17:43:08 -0500 MIME-Version: 1.0 In-Reply-To: <20170301165355.w2kmdmbql2f2ouzg@treble> References: <20161010125709.1870563-1-arnd@arndb.de> <20161011150541.opini6gbolmnpzy5@treble> <20161011155146.icyl3zewdvmms2h2@treble> <2252957.Vm1BYSSRqP@wuerfel> <20170301144008.3ocnbvry4sbl3cnu@treble> <20170301165355.w2kmdmbql2f2ouzg@treble> From: Arnd Bergmann Date: Wed, 1 Mar 2017 23:42:54 +0100 X-Google-Sender-Auth: jw3OGt8d6ybdSBF2FPJKpX6hSzY Message-ID: Subject: Re: [PATCH] [RFC] x86: avoid -mtune=atom for objtool warnings To: Josh Poimboeuf Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Linux Kernel Mailing List , Denys Vlasenko Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 1, 2017 at 5:53 PM, Josh Poimboeuf wrote: > On Wed, Mar 01, 2017 at 04:27:29PM +0100, Arnd Bergmann wrote: > I see no apparent reason for the ud2. It's the possible division by zero. This change would avoid the ud2: diff --git a/drivers/i2c/busses/i2c-img-scb.c b/drivers/i2c/busses/i2c-img-scb.c index db8e8b40569d..a2b09c518225 100644 --- a/drivers/i2c/busses/i2c-img-scb.c +++ b/drivers/i2c/busses/i2c-img-scb.c @@ -1196,6 +1196,8 @@ static int img_i2c_init(struct img_i2c *i2c) clk_khz /= prescale; /* Setup the clock increment value */ + if (clk_khz < 1) + clk_khz = 1; inc = (256 * 16 * bitrate_khz) / clk_khz; /* Arnd