From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966839AbdD0Lxu (ORCPT ); Thu, 27 Apr 2017 07:53:50 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:34654 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752053AbdD0Lxn (ORCPT ); Thu, 27 Apr 2017 07:53:43 -0400 MIME-Version: 1.0 In-Reply-To: <1493290972.18400.40.camel@nxp.com> References: <1493212192-7930-1-git-send-email-daniel.baluta@nxp.com> <1493212192-7930-2-git-send-email-daniel.baluta@nxp.com> <1493290972.18400.40.camel@nxp.com> From: Arnd Bergmann Date: Thu, 27 Apr 2017 13:53:42 +0200 X-Google-Sender-Auth: 7C-gAL2qxH_sRd7nbPXYLcS2mUw Message-ID: Subject: Re: [PATCH v2 1/2] ASoC: codec: wm9860: avoid maybe-uninitialized warning To: Daniel Baluta Cc: "lgirdwood@gmail.com" , "ckeepax@opensource.wolfsonmicro.com" , "linux-kernel@vger.kernel.org" , "patches@opensource.wolfsonmicro.com" , "broonie@kernel.org" , "tiwai@suse.com" , "alsa-devel@alsa-project.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 27, 2017 at 1:02 PM, Daniel Baluta wrote: > On Jo, 2017-04-27 at 12:07 +0200, Arnd Bergmann wrote: >> On Wed, Apr 26, 2017 at 3:09 PM, Daniel Baluta > > wrote: >> > >> > The new PLL configuration code triggers a harmless warning: >> > >> > sound/soc/codecs/wm8960.c: In function 'wm8960_configure_clocking': >> > sound/soc/codecs/wm8960.c:735:3: error: 'best_freq_out' may be used >> > uninitialized in this function [-Werror=maybe-uninitialized] >> > wm8960_set_pll(codec, freq_in, best_freq_out); >> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> > sound/soc/codecs/wm8960.c:699:12: note: 'best_freq_out' was >> > declared >> > here >> > >> > Fix this by reworking the code such that: >> > >> > 1) When there is no PLL freq available return -EINVAL and make >> > sure *bclk_idx, *dac_idx, *sysclk_idx are initialized with >> > invalid values. >> > >> > 2) When there is a PLL freq available initialize *bclk_idx, >> > *dac_idx and *sysclk_idx with correct values and immediately >> > return the freq available. >> > >> > Fixes: 84fdc00d519f ("ASoC: codec: wm9860: Refactor PLL out freq >> > search") >> > Fixes: 303e8954af8d ("ASoC: codec: wm8960: Stop when a matching PLL >> > freq is found") >> > Suggested-by: Arnd Bergmann >> > Signed-off-by: Daniel Baluta >> Looks good to me. Let me know if you need me to test this more >> thoroughly >> with randconfig builds, otherwise I'll assume it's fine and it will >> get tested once >> it shows up in linux-next. >> >> Acked-by: Arnd Bergmann >> > > Hi Arnd, > > Thanks for doing this. I wouldn't expect randconfigs builds to show > other issues. > > Anyhow, would like to see if with your compiler there are no warnings > for the second patch of the series: > > http://mailman.alsa-project.org/pipermail/alsa-devel/2017-April/120177.html I've applied both patches to my randconfig tree now. The configuration that first showed the problem works fine now, but with -Wmaybe-uninitialized warnings I try to do additional randconfig tests as sometimes the warnings come back depending on some other inlining decisions or optimization flags. Arnd