From: Arnd Bergmann <arnd@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Tal Zussman <tz2294@columbia.edu>, Arnd Bergmann <arnd@arndb.de>,
Linux API <linux-api@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH] syscalls: Fix file comments for syscalls implemented in kernel/sys.c
Date: Mon, 16 Nov 2020 17:44:00 +0100 [thread overview]
Message-ID: <CAK8P3a2JyaGj2GJXYac-hURK1Z54D6cnU4qYZmV3L4pVLifBLA@mail.gmail.com> (raw)
In-Reply-To: <20201116162311.GA15585@infradead.org>
On Mon, Nov 16, 2020 at 5:23 PM Christoph Hellwig <hch@infradead.org> wrote:
>
> On Thu, Nov 12, 2020 at 04:56:57PM -0500, Tal Zussman wrote:
> > The relevant syscalls were previously moved from kernel/timer.c to kernel/sys.c,
> > but the comments weren't updated to reflect this change.
> >
> > Fixing these comments messes up the alphabetical ordering of syscalls by
> > filename. This could be fixed by merging the two groups of kernel/sys.c syscalls,
> > but that would require reordering the syscalls and renumbering them to maintain
> > the numerical order in unistd.h.
>
> Lots of overly long lines in your commit log.
>
> As for the patch itself: IMHO we should just remove the comments
> about the files as that information is completely irrelevant.
I noticed I already applied the patch last week to the asm-generic cleanups
branch, but forgot to send out the email about it.
I do agree the file names are rather useless, and I would apply a follow-up
patch to completely remove them as well. My real plan was to remove
the file itself and replace it with the parsable syscall.tbl format that we
use for all non-generic architectures, but I haven't gotten around to updating
the patch that Firoz Khan did a long time ago.
arnd
prev parent reply other threads:[~2020-11-16 16:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 21:56 [PATCH] syscalls: Fix file comments for syscalls implemented in kernel/sys.c Tal Zussman
2020-11-16 16:23 ` Christoph Hellwig
2020-11-16 16:44 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a2JyaGj2GJXYac-hURK1Z54D6cnU4qYZmV3L4pVLifBLA@mail.gmail.com \
--to=arnd@kernel.org \
--cc=arnd@arndb.de \
--cc=hch@infradead.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tz2294@columbia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).