From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78296ECDE44 for ; Wed, 24 Oct 2018 22:53:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 33FBA2075D for ; Wed, 24 Oct 2018 22:53:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33FBA2075D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726901AbeJYHXX (ORCPT ); Thu, 25 Oct 2018 03:23:23 -0400 Received: from mail-qk1-f196.google.com ([209.85.222.196]:35279 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725829AbeJYHXW (ORCPT ); Thu, 25 Oct 2018 03:23:22 -0400 Received: by mail-qk1-f196.google.com with SMTP id v68-v6so4530683qka.2; Wed, 24 Oct 2018 15:53:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+U50XVBot4H7FGuOkQDmHUygidnKMymT4Rk77k+9HhE=; b=RIPXXYTGXnhx0Vwx/Ac12JfcxKg5AinEl+R4pOYH7wREp1VSBs34VnJozxlfhOy6zu b+tF5GX2acSw2mN+RMs2lflfPpIaUAuMnIDnKiESdreJAYQ7t4w2WWmQUZVaWVjR7ypk pksemh2BHpVfTjPstkJWWIMrODQLRVUGCtKaL/T6ASespOCg51z7GwzMm+HEWqz588yy 7gFOYFTQshrXTzlJB55r+HPA3J88TencMEJK1wkpldJIrj+7nFEdRqC7zswyvC9H97Qy oqSYyQA12BCIh7fWKkzxmHUwNnp4TvMdxPNLiSMr/3elvyUz2m8uBL60S9+ygKdHwM/V GWEw== X-Gm-Message-State: AGRZ1gL1r8lYX+Jird/k8xlP4N5tZ5UYRgSiDx9JqZ1H6bXGg8NZWlpQ ZsnQM3KEF0YVXBGrFh6ssKxeTn+MwnQUaxHZ7OrnyZPW X-Google-Smtp-Source: AJdET5cykiGAFQS4f+VrDmFh99HwMxrJ5HNUUZivptgQ1MAlrWaR2sYdst+thZ9K1idPerxm3SfpNHEvpPnykSWykS8= X-Received: by 2002:a37:9886:: with SMTP id a128-v6mr4041112qke.343.1540421603509; Wed, 24 Oct 2018 15:53:23 -0700 (PDT) MIME-Version: 1.0 References: <801add6d63256a3bf0802e2b03efb0f9c206dab0.1539655731.git.ren_guo@c-sky.com> <20181023000834.GA20335@guoren-Inspiron-7460> In-Reply-To: <20181023000834.GA20335@guoren-Inspiron-7460> From: Arnd Bergmann Date: Wed, 24 Oct 2018 23:53:05 +0100 Message-ID: Subject: Re: [PATCH V9 01/21] csky: Build infrastructure To: Guo Ren Cc: Linux Kernel Mailing List , linux-arch Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 23, 2018 at 1:08 AM Guo Ren wrote: > > Hi Arnd, > > Could you help me review the patch, seems the patch is skipped. > ref: https://lkml.org/lkml/2018/10/16/224 Ah right, I missed that. I think I originally had some thoughts on it but didn't immediately comment and then forgot about it. It's basically ok, so Acked-by: Arnd Bergmann but please have a look below for a follow-up patch: > > diff --git a/arch/csky/include/asm/Kbuild b/arch/csky/include/asm/Kbuild > > new file mode 100644 > > index 0000000..014eb57 > > --- /dev/null > > +++ b/arch/csky/include/asm/Kbuild > > @@ -0,0 +1,72 @@ > > +generic-y += asm-offsets.h > > +generic-y += bitsperlong.h > > +generic-y += bugs.h > > +generic-y += clkdev.h > > +generic-y += compat.h > > +generic-y += current.h > > +generic-y += delay.h > > +generic-y += device.h > > +generic-y += div64.h ... > > +generic-y += errno.h ... > > +generic-y += ioctl.h > > +generic-y += ioctls.h A number of the header files that are marked as generic-y in asm/Kbuild are also marked the same way in uapi/asm/Kbuild. I think this is a mistake, since we only need one of the two for each header. When both exist, we just take the one from asm/, but then we install the uapi/asm/ version in the 'make headers_install' stage, and they both have the same contents, so I think you only need the uapi/asm/ version here. > > diff --git a/arch/csky/include/uapi/asm/Kbuild b/arch/csky/include/uapi/asm/Kbuild > > new file mode 100644 > > index 0000000..b65252b > > --- /dev/null > > +++ b/arch/csky/include/uapi/asm/Kbuild > > @@ -0,0 +1,33 @@ > > +include include/uapi/asm-generic/Kbuild.asm > > + > > +header-y += cachectl.h > > +header-y += stat.h It also seems that the second statement here (for stat.h) is from an older version, since that header no longer exists, at least if I'm reading your patches correctly. Arnd