From: Arnd Bergmann <arnd@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Peter Anvin <hpa@zytor.com>, Heiko Carstens <hca@linux.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>, Arnd Bergmann <arnd@arndb.de>,
Matthew Wilcox <willy@infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
"the arch/x86 maintainers" <x86@kernel.org>
Subject: Re: [PATCH] epoll: fix compat syscall wire up of epoll_pwait2
Date: Mon, 21 Dec 2020 00:18:32 +0100 [thread overview]
Message-ID: <CAK8P3a2fUpnhxmOPbzD=z10_uuWQsHyEUv+YQ19wNWrxiUVwvQ@mail.gmail.com> (raw)
In-Reply-To: <CAHk-=wimOSd-41nDAYKfbUCNN=o22NOrGT6U38=KLqw5NBsZNg@mail.gmail.com>
On Sun, Dec 20, 2020 at 10:06 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> On Sun, Dec 20, 2020 at 12:14 PM Arnd Bergmann <arnd@kernel.org> wrote:
> >
> > The sigset_t argument is actually compatible between x86-32 and x86-64
>
> Well, random high bits in size_t or the pointer value aren't. So it
> still looks a bit iffy to me.
>
> But it might end up working almost by accident.
The direct syscall arguments all get the correct zero-extension with
asm/syscall_wrapper.h, just like they do with any other syscall that
is used in both native and compat mode, like epoll_wait().
It probably makes sense to change it just for consistency with the other
architectures, but I would assume that it was intentional when this was
added originally, as the compat handling for epoll_pwait() went through
several iterations before it first worked correctly.
Arnd
next prev parent reply other threads:[~2020-12-20 23:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-20 9:58 [PATCH] epoll: fix compat syscall wire up of epoll_pwait2 Heiko Carstens
2020-12-20 11:43 ` Arnd Bergmann
2020-12-20 18:22 ` Willem de Bruijn
2020-12-20 18:51 ` Linus Torvalds
2020-12-20 20:14 ` Arnd Bergmann
2020-12-20 21:06 ` Linus Torvalds
2020-12-20 23:18 ` Arnd Bergmann [this message]
2020-12-23 14:48 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a2fUpnhxmOPbzD=z10_uuWQsHyEUv+YQ19wNWrxiUVwvQ@mail.gmail.com' \
--to=arnd@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=borntraeger@de.ibm.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=tsbogend@alpha.franken.de \
--cc=viro@zeniv.linux.org.uk \
--cc=will@kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).