From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28CEBC433E7 for ; Mon, 12 Oct 2020 13:38:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D7E6E221FE for ; Mon, 12 Oct 2020 13:38:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731135AbgJLNiN (ORCPT ); Mon, 12 Oct 2020 09:38:13 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:34045 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731063AbgJLNh3 (ORCPT ); Mon, 12 Oct 2020 09:37:29 -0400 Received: from mail-qt1-f180.google.com ([209.85.160.180]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MplHR-1k7UF80lKf-00qCkJ; Mon, 12 Oct 2020 15:37:27 +0200 Received: by mail-qt1-f180.google.com with SMTP id t9so12754153qtp.9; Mon, 12 Oct 2020 06:37:26 -0700 (PDT) X-Gm-Message-State: AOAM531KfO80OiUdKbULvlE7u+ajp17ruQsmKmwWidIxmbypU2fsJxSj VRf+hhySJ1jrrndxCl4J4quYUeyoSLC6ZtioMwU= X-Google-Smtp-Source: ABdhPJw6Xw5QPFz9Hbm4r+y0vTuo5ru8d6HOL66whTmsLJNolGIOqnjXdgx88Su9kNbZVfsNfxwFqVNIjbZi+UQICLY= X-Received: by 2002:ac8:64a:: with SMTP id e10mr9800808qth.142.1602509845710; Mon, 12 Oct 2020 06:37:25 -0700 (PDT) MIME-Version: 1.0 References: <20201008154651.1901126-1-arnd@arndb.de> <20201008154651.1901126-12-arnd@arndb.de> In-Reply-To: From: Arnd Bergmann Date: Mon, 12 Oct 2020 15:37:09 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 11/13] timekeeping: remove xtime_update To: Geert Uytterhoeven Cc: Linux Kernel Mailing List , Russell King , Tony Luck , Fenghua Yu , Greg Ungerer , Finn Thain , Philip Blundell , Joshua Thompson , Sam Creasey , "James E.J. Bottomley" , Helge Deller , Thomas Gleixner , Daniel Lezcano , John Stultz , Stephen Boyd , Linus Walleij , "linux-ia64@vger.kernel.org" , Parisc List , linux-m68k , Linux ARM Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:BsBR49K4r9UqORnUI2CXH8prW1C1pgsCLtwNP9oJZoTdaQ5Mp61 xb0TEXecnuEb6oz01w7+jTBY2d/0EavRHDItoBlHJIVfqcDpU4stdtGGZW5++LdQY83ej1t VpUFQGsDhFBz648k0OEzrPO7frTTuY3i/9ew8y/3T/xxk35vnSYHDYmj5qbLTuCaQa47RIo FrPmmcWbLHpeA1d6x9dJA== X-UI-Out-Filterresults: notjunk:1;V03:K0:0Hfyhez933s=:Ra979ud5Mj/4+53raRBR1X Santde6uyHWKyZGpYcYs0Rh1/fGxyN7Qcd9H1PsB/ITC0PZGcH6faVz1Edm4WYONmv6S3QaGC x2cRhsOcqPdZNiOngQ/bMcHS4nWXcLjSEyywZQbaNXfrhYHCIgzshRTV8tFGqXQlx1aarJkLy xpl7PVFGH/gbyP2FEZykcVZoLubpwfiNNoHES7ZAIPgLUrMjGfRyxSo4gF6gtk6r+1CgW82iy GmjQ2Bi08cTm83IaS4ijdxUvilSQJrKlRSIA9hew5jIn/BgtoQ3c2RfPkyooXstZ06BX0peV/ PvyyyeuA/qO9ohS//CbaYXUnLyKhsjSsokiOqdS7L3+u0vowzlR1E7pf3oLeuqu1WpcmM+Vwl XaAOI1SbrN00dzkJbrYvy6A2bLpXOxHAgcPj4yV4Ev4TsifkpyJQUNeu4hgoQtQCzbsfiy7Di hNEoxoU3TKp7FwmdtlDK5g7lBUCCo4lNMVwYloKptfk36zX2qUF/LxcI7scqtoiKvj+JOT7+n ZRXf23YDkGVlpRNSfE/GRvRwjfzXHTJka0NUTY3PCBpi73utda45FN8ODHZ+dKUFOxIwRxC95 I1rmF1BIFXC9WriyIjO9DRtmvlikyfGOHfXmS9Kzm2VJDa0miiKaTUeCNex3+FBEt2GSMbf7h tm/8X7fS/49saP9SWbaETnxtJUG9FjSCeTmFqg0MVZ/5Dc6UcfLauZxsYshjps2lXsdV8yG59 zs+4Mh8ObXjNw7wxJZzLXnE7i3pFO9m9Lyh5x5ocxaANIA49B4nlFp/4B5oLiTGwrSmAPBDOr +QA4bVe4PCZYri9gfrJTBCR23hrtEsWi+RWvLq+CZKwNSmY9o5fVVbzOIwj8gQ5TwxYK9SoDx p2XRAHyD+p55aCrB2H232gE5+5law6/U0QnEQoO8ptRKMKEeo4HzQpE6ng3Q74PKU36Tw5F+j AqS0kNUDHoWpyAM/nlFEMqKawd+3JVrN13s7TcVRu/3D1OyJ0JWWy Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 12, 2020 at 3:16 PM Geert Uytterhoeven wrote: > On Thu, Oct 8, 2020 at 5:48 PM Arnd Bergmann wrote: > > There are no more users of xtime_update aside from legacy_timer_tick(), > > so fold it into that function and remove the declaration. > > > > update_process_times() is now only called inside of the kernel/time/ > > code, so the declaration can be moved there. > > > > Signed-off-by: Arnd Bergmann > > Thanks for your patch! > > Reviewed-by: Geert Uytterhoeven > > The comment about xtime_update() in arch/ia64/kernel/time.c needs > an update. I think the correct action for ia64 would be to make it a proper clockevent driver with oneshot support, and remove the rest of this logic. I could try to rewrite the comment, but I tried not to touch that part since I don't understand the logic behind it. Maybe the ia64 maintainers can comment here why it even tries to skip a timer tick. Is there a danger of ending up with the timer irq permanently disabled if the timer_interrupt() function returns with the itm register in the past, or is this simply about not having too many interrupts in a row? > Does the comment about update_process_times() in > arch/openrisc/kernel/time.c needs an update, too? I think that one is still technically correct. Arnd