From: Arnd Bergmann <arnd@arndb.de>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Niklas Cassel <niklas.cassel@linaro.org>,
Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Jassi Brar <jaswinder.singh@linaro.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mbox: qcom: avoid unused-variable warning
Date: Fri, 20 Sep 2019 21:27:50 +0200 [thread overview]
Message-ID: <CAK8P3a2j6QG19i3YtRPh7qD4Zr5TiHmK_5=s9mSD2pHVmE99HA@mail.gmail.com> (raw)
In-Reply-To: <20190920164545.68FFB20717@mail.kernel.org>
On Fri, Sep 20, 2019 at 6:45 PM Stephen Boyd <sboyd@kernel.org> wrote:
> > @@ -54,11 +60,6 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev)
> > void __iomem *base;
> > unsigned long i;
> > int ret;
> > - const struct of_device_id apcs_clk_match_table[] = {
>
> Does marking it static here work too? It would be nice to limit the
> scope of this variable to this function instead of making it a global.
> Also, it might be slightly smaller code size if that works.
No, I just tried and the warning returned.
Arnd
next prev parent reply other threads:[~2019-09-20 19:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 14:55 [PATCH] mbox: qcom: avoid unused-variable warning Arnd Bergmann
2019-09-20 16:45 ` Stephen Boyd
2019-09-20 19:27 ` Arnd Bergmann [this message]
[not found] ` <20190920210622.51382205F4@mail.kernel.org>
2019-09-26 13:07 ` Geert Uytterhoeven
2019-09-27 18:26 ` Stephen Boyd
2019-09-27 19:10 ` Geert Uytterhoeven
2019-10-03 21:16 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a2j6QG19i3YtRPh7qD4Zr5TiHmK_5=s9mSD2pHVmE99HA@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=jassisinghbrar@gmail.com \
--cc=jaswinder.singh@linaro.org \
--cc=jorge.ramirez-ortiz@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=niklas.cassel@linaro.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).