From: Arnd Bergmann <arnd@arndb.de>
To: Vinod Koul <vinod.koul@intel.com>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Harsha Priya N <harshapriya.n@intel.com>,
Naveen M <naveen.m@intel.com>,
alsa-devel@alsa-project.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: fix Kconfig dependencies
Date: Thu, 2 Nov 2017 17:25:01 +0100 [thread overview]
Message-ID: <CAK8P3a2jXrL2-eEZ0h_ay6CR45quzVjiqD5dWxubz29rVpxFYA@mail.gmail.com> (raw)
In-Reply-To: <20171102160406.GG3187@localhost>
On Thu, Nov 2, 2017 at 5:04 PM, Vinod Koul <vinod.koul@intel.com> wrote:
> On Thu, Nov 02, 2017 at 02:12:11PM +0100, Arnd Bergmann wrote:
>> On Thu, Nov 2, 2017 at 2:04 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>> > On Thu, Nov 2, 2017 at 1:43 PM, Pierre-Louis Bossart
>> > <pierre-louis.bossart@linux.intel.com> wrote:
>> >> On 11/2/17 6:07 AM, Arnd Bergmann wrote:
>> >>>
>> >>> I ran into multiple problems during randconfig builds of the
>> >>> recently changed Kconfig logic for Intel ASoC drivers:
>> >>
>> >>
>> >> we did quite a bit of testing on this change, looks like we missed a number
>> >> of cases. Gah.
>> >>
>> >>>
>> >>> - Building without DMADEVICES doesn't work in general
>> >>
>> >>
>> >> the Intel audio hardware has its own DMA in general, be it based on
>> >> DesignWare controlled by audio firmware or HDaudio, not sure if/why this
>> >> dependency is needed across the board?
>> >
>> > Probably my mistake. I'll try again without the dependency and see
>> > what problems I run into then and what the correct fix is.
>>
>> I immediately ran into this Kconfig warning, so this is clearly for the two
>> users of SND_SOC_INTEL_SST_FIRMWARE:
>>
>> warning: (SATA_DWC_OLD_DMA && SERIAL_8250_LPSS &&
>> SND_SOC_INTEL_SST_FIRMWARE) selects DW_DMAC_CORE which has unmet
>> direct dependencies (DMADEVICES)
>
> The BYT legacy drivers used DMAengine (dw) to load the firmware and hence the
> dependency. The Skylake and other drivers do not need that, so we should
> move this from toplevel to the BYT driver only.
Ok, so Haswell also shouldn't select SND_SOC_INTEL_SST_FIRMWARE, right?
>> config SND_SOC_INTEL_SST_FIRMWARE
>> tristate
>> - select DW_DMAC_CORE
>
> this is required as we need this DMA driver. It might not have issues on
> compile but functionality would be broken.
It's also broken at compile time, I just ran into that.
>> config SND_SOC_INTEL_SST_ACPI
>> tristate
>> @@ -32,19 +31,20 @@ config SND_SOC_ACPI_INTEL_MATCH
>> config SND_SOC_INTEL_SST_TOPLEVEL
>> tristate "Intel ASoC SST drivers"
>> depends on X86 || COMPILE_TEST
>> - depends on DMADEVICES
>
> This is fine
>
>> select SND_SOC_INTEL_MACH
>> select SND_SOC_INTEL_COMMON
>>
>> config SND_SOC_INTEL_HASWELL
>> tristate "Intel ASoC SST driver for Haswell/Broadwell"
>> depends on SND_SOC_INTEL_SST_TOPLEVEL && SND_DMA_SGBUF
>> + depends on DMADEVICES
>
> yes this and below seems right fix to me.
Ok, thanks for taking a look! I'll let the randconfig builder chew on this
overnight, and send a new version tomorrow.
Arnd
next prev parent reply other threads:[~2017-11-02 16:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 11:07 [PATCH] ASoC: Intel: fix Kconfig dependencies Arnd Bergmann
2017-11-02 11:21 ` Applied "ASoC: Intel: fix Kconfig dependencies" to the asoc tree Mark Brown
2017-11-02 12:43 ` [alsa-devel] [PATCH] ASoC: Intel: fix Kconfig dependencies Pierre-Louis Bossart
2017-11-02 13:04 ` Arnd Bergmann
2017-11-02 13:12 ` Arnd Bergmann
2017-11-02 16:04 ` Vinod Koul
2017-11-02 16:25 ` Arnd Bergmann [this message]
2017-11-02 16:32 ` Vinod Koul
2017-11-02 20:25 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a2jXrL2-eEZ0h_ay6CR45quzVjiqD5dWxubz29rVpxFYA@mail.gmail.com \
--to=arnd@arndb.de \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=harshapriya.n@intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=naveen.m@intel.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).