From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80156C433E9 for ; Fri, 15 Jan 2021 11:16:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5BB4623356 for ; Fri, 15 Jan 2021 11:16:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729280AbhAOLQI (ORCPT ); Fri, 15 Jan 2021 06:16:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:42058 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726983AbhAOLQG (ORCPT ); Fri, 15 Jan 2021 06:16:06 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5C690224F9; Fri, 15 Jan 2021 11:15:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610709325; bh=l6kjuUdwH1J+0RSW3wOI8b+Ktrck5Pp8whJGF52QkIE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=PD/jyBuFD2zBhD/OKowdt7KUWwTIyVCxfiXOKXd/u8LnOCRaTxgyl0c/dKc204zAl MFkS1prtkZoWd3JY6bRSz/ESUYjdsatSAcWeMzMHV59Q/wnhLbOpLX/lMeE3Jn9klf egE12hfzBfcmhrBKz4x3+iE3T3GOTBQFJ0HiknW3CrCy4rRoezLB2RrvfYhgGqCx3R hhXh4Iv8/qru2WVCA4LYvShzcB65v04yIFSfIea8fl1D+3k+HIqOPNJzF2AWaEzAwG nIWjSQkSF1Vgw68u8WIzLjnokG/XNLsi2h8F7A8tpZBhS7M27y0iqLGi1JIn412d10 Q3nXe7uVrMHSw== Received: by mail-ot1-f53.google.com with SMTP id n42so8140977ota.12; Fri, 15 Jan 2021 03:15:25 -0800 (PST) X-Gm-Message-State: AOAM531V9ZeU814aJUIXp/MKTtAvb8T+qa7j9cLE3DbJkgyNRsw6bdYK QWLqDrxXYOrLWE3vPox/fB8QtIgkDS9Tw1tQ7oU= X-Google-Smtp-Source: ABdhPJxdT2yiEyJyQ1PSbCV6Z82EpynBxTRjdqIE6EVKUyyA7+bqwnepWK2E/W6nJKmTGyHoKeCVn1KG1j/QiHnz1v0= X-Received: by 2002:a9d:741a:: with SMTP id n26mr615881otk.210.1610709324684; Fri, 15 Jan 2021 03:15:24 -0800 (PST) MIME-Version: 1.0 References: <20210110115245.30762-1-alobakin@pm.me> <202101111153.AE5123B6@keescook> <20210111205649.18263-1-alobakin@pm.me> <20210111224305.GA22825@alpha.franken.de> In-Reply-To: <20210111224305.GA22825@alpha.franken.de> From: Arnd Bergmann Date: Fri, 15 Jan 2021 12:15:08 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 mips-next 0/9] MIPS: vmlinux.lds.S sections fixes & cleanup To: Thomas Bogendoerfer Cc: Alexander Lobakin , Kees Cook , Arnd Bergmann , Nathan Chancellor , Nick Desaulniers , Huacai Chen , Pei Huang , Fangrui Song , Jiaxun Yang , Ralf Baechle , Corey Minyard , "open list:BROADCOM NVRAM DRIVER" , "linux-kernel@vger.kernel.org" , linux-arch , "# 3.4.x" , clang-built-linux Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 11, 2021 at 11:44 PM Thomas Bogendoerfer wrote: > On Mon, Jan 11, 2021 at 08:57:25PM +0000, Alexander Lobakin wrote: > > From: Kees Cook > > Date: Mon, 11 Jan 2021 11:53:39 -0800 > > > > > On Sun, Jan 10, 2021 at 11:53:50AM +0000, Alexander Lobakin wrote: > > >> This series hunts the problems discovered after manual enabling of > > >> ARCH_WANT_LD_ORPHAN_WARN. Notably: > > >> - adds the missing PAGE_ALIGNED_DATA() section affecting VDSO > > >> placement (marked for stable); > > >> - stops blind catching of orphan text sections with .text.* > > >> directive; > > >> - properly stops .eh_frame section generation. > > >> > > >> Compile and runtime tested on MIPS32R2 CPS board with no issues > > >> using two different toolkits: > > >> - Binutils 2.35.1, GCC 10.2.1 (with Alpine patches); > > >> - LLVM stack: 11.0.0 and from latest Git snapshot. > > >> > > >> Since v4 [3]: > > >> - new: drop redundant .text.cps-vec creation and blind inclusion > > >> of orphan text sections via .text.* directive in vmlinux.lds.S; > > >> - don't assert SIZEOF(.rel.dyn) as it's reported that it may be not > > >> empty on certain machines and compilers (Thomas); > > >> - align GOT table like it's done for ARM64; > > >> - new: catch UBSAN's "unnamed data" sections in generic definitions > > >> when building with LD_DEAD_CODE_DATA_ELIMINATION; > > >> - collect Reviewed-bys (Kees, Nathan). > > > > > > Looks good; which tree will this land through? > > > > linux-mips/mips-next I guess, since 7 of 9 patches are related only > > to this architecture. > > This might need Arnd's Acked-bys or Reviewed-by for the two that > > refer include/asm-generic, let's see what Thomas think. > > Looks good from my side and I have it already sitting in branch for > submission. > > Arnd, are you ok with the changes in include/asm-generic ? Yes, I'm never quite sure about what to make of linker script changes, but I trust Kees on the review. For merging it through your tree: Acked-by: Arnd Bergmann