From: Arnd Bergmann <arnd@arndb.de>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Olof Johansson <olof@lixom.net>, arm-soc <arm@kernel.org>,
SoC Team <soc@kernel.org>, Kukjin Kim <kgene@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES"
<linux-samsung-soc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
DTML <devicetree@vger.kernel.org>
Subject: Re: [GIT PULL 1/2] arm64: dts: exynos: Pull for v5.4
Date: Wed, 11 Sep 2019 23:07:17 +0200 [thread overview]
Message-ID: <CAK8P3a2pBV+fh0rHitZ30Zz61QNRLfNSD-nhnzq4ZtxSh66F1Q@mail.gmail.com> (raw)
In-Reply-To: <20190911183632.4317-1-krzk@kernel.org>
On Wed, Sep 11, 2019 at 8:36 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> Hi,
>
> Unfortunately the patches were applied right after closing the linux-next.
Hi Krzysztof,
I took a look at these and am not convinced this is right:
> 1. Fix boot of Exynos7 due to wrong address/size of memory node,
The current state is clearly broken and a fix is needed, but
I'm not sure this is the right fix. Why do you have 32-bit physical
addressing on a 64-bit chip? I looked at commit ef72171b3621
that introduced it, and it seems it would be better to just
revert back to 64-bit addresses.
> 2. Move GPU under /soc node,
No problem
> 3. Minor cleanup of #address-cells.
IIRC, an interrupt-controller is required to have a #address-cells
property, even if that is normally zero. I don't remember the
details, but the gic binding lists it as mandatory, and I think
the PCI interrupt-map relies on it. I would just drop this patch.
Arnd
next prev parent reply other threads:[~2019-09-11 21:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 18:36 [GIT PULL 1/2] arm64: dts: exynos: Pull for v5.4 Krzysztof Kozlowski
2019-09-11 18:36 ` [GIT PULL 2/2] ARM: samsung: mach/soc for v5.4, second pull Krzysztof Kozlowski
2019-09-11 21:10 ` Arnd Bergmann
2019-09-11 21:07 ` Arnd Bergmann [this message]
2019-09-12 6:32 ` [GIT PULL 1/2] arm64: dts: exynos: Pull for v5.4 Krzysztof Kozlowski
2019-09-12 6:56 ` Marek Szyprowski
2019-09-12 9:35 ` Krzysztof Kozlowski
2019-09-29 17:51 ` Olof Johansson
2019-09-30 8:02 ` Krzysztof Kozlowski
2019-09-30 17:35 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a2pBV+fh0rHitZ30Zz61QNRLfNSD-nhnzq4ZtxSh66F1Q@mail.gmail.com \
--to=arnd@arndb.de \
--cc=arm@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).