From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14C2EC43460 for ; Tue, 18 May 2021 07:48:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7B9C60FE7 for ; Tue, 18 May 2021 07:48:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347269AbhERHt6 (ORCPT ); Tue, 18 May 2021 03:49:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:38258 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234891AbhERHt5 (ORCPT ); Tue, 18 May 2021 03:49:57 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 67B5160FE7; Tue, 18 May 2021 07:48:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621324119; bh=ZvGkPYlYj2nqGmESCnOClTJykmU52wuUqDlRt38OfA0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=DxfI8vWupsEgScwwsgAAWaxLJODkg+jRKN42nvXRZIK7KuL5kQQLP99tuTwCTBXnS uafZ90muV++LA/p87BnSyCSSaSthDNw8iBlfyRmq3XSQhoQPVu2hIXJIJ4bLVwGCNQ S6g5yQPH9vfxZAL3h5odLDBQ/uENnw/EUrtB8sOw+AsUfN0dwdy8Z9p0/fu00Or1YG HSfkXCgy+lvz5mtA05ZmHPfItVnnUAt6A9a1FiPhBIeOkuAuxW0MXsfBgkAd2C5L6J uVWbchBFvSPmyqEWTUmAMeA5EeJ7XTJN9VrrFIhLkPltUvZRkWLmk2Jq9qQqWHsU8C 5eJ6eIHy6orkA== Received: by mail-wm1-f51.google.com with SMTP id o6-20020a05600c4fc6b029015ec06d5269so929404wmq.0; Tue, 18 May 2021 00:48:39 -0700 (PDT) X-Gm-Message-State: AOAM533NMaYYIwZuqdhQylWxIUqBT1el+NwbORnn4EgXzd0akBSt067k JcN8s6LxeFRoBo037rOrVzgNbyI2QKCvDthclI8= X-Google-Smtp-Source: ABdhPJz4k8XxX24/Dox9+GySTr8wlMSmxqo+SuzqOQF2aXlWbf96HeHqVkq/eJMb4rVErJpv4OfcoAmTm6cuSeTNHgA= X-Received: by 2002:a7b:c849:: with SMTP id c9mr3442580wml.84.1621324118063; Tue, 18 May 2021 00:48:38 -0700 (PDT) MIME-Version: 1.0 References: <20210517203343.3941777-1-arnd@kernel.org> <20210517203343.3941777-2-arnd@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Tue, 18 May 2021 09:47:27 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 1/4] kexec: simplify compat_sys_kexec_load To: Christoph Hellwig Cc: linux-arch , Alexander Viro , Andrew Morton , Borislav Petkov , Brian Gerst , Eric Biederman , Ingo Molnar , "H. Peter Anvin" , Thomas Gleixner , Linux ARM , Linux Kernel Mailing List , Linux-MM , kexec@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 18, 2021 at 8:38 AM Christoph Hellwig wrote: > > > + if (in_compat_syscall()) > > + return copy_user_compat_segment_list(image, nr_segments, segments); > > Annoying overly lone line here. Oops, I was sure I had fixed all of these when you pointed this out before. I probably rebased a slightly older branch that did not have the fixes. > Otherwise: > > Reviewed-by: Christoph Hellwig Thanks, Arnd