From: Arnd Bergmann <arnd@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-arch <linux-arch@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Vineet Gupta <vgupta@synopsys.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Brian Cain <bcain@codeaurora.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>, Jeff Dike <jdike@addtoit.com>,
Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Sid Manning <sidneym@codeaurora.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@kernel.org>,
"open list:SYNOPSYS ARC ARCHITECTURE"
<linux-snps-arc@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"moderated list:H8/300 ARCHITECTURE"
<uclinux-h8-devel@lists.sourceforge.jp>,
"open list:QUALCOMM HEXAGON..." <linux-hexagon@vger.kernel.org>,
linux-m68k <linux-m68k@lists.linux-m68k.org>,
linux-riscv <linux-riscv@lists.infradead.org>,
linux-um <linux-um@lists.infradead.org>
Subject: Re: [PATCH 0/5] asm-generic: strncpy_from_user/strnlen_user cleanup
Date: Sat, 15 May 2021 11:55:10 +0200 [thread overview]
Message-ID: <CAK8P3a2ukLgV3K3sW8gkkz6cvKh+wmP_C0av2hnYcftfXMPTWA@mail.gmail.com> (raw)
In-Reply-To: <20210515064015.GA26545@lst.de>
On Sat, May 15, 2021 at 8:40 AM Christoph Hellwig <hch@lst.de> wrote:
>
> I generall like this consolidation, but for the patches that remote
> the arch / asm-generic versions, can you please elaborate a little
> more why the lib version is preferable? The current commit logs are
> not very informative.
Indeed. I do remember writing the patches last year thinking "this should
really get fixed", but apparently I failed to describe the actual problem at
the time. I have gone through it again and annotated what I found now,
but I have a feeling that there were additional problems with the old
code that I still did not capture.
Sending v2 now: same code, more text.
Arnd
prev parent reply other threads:[~2021-05-15 9:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 22:09 [PATCH 0/5] asm-generic: strncpy_from_user/strnlen_user cleanup Arnd Bergmann
2021-05-14 22:09 ` [PATCH 1/5] asm-generic/uaccess.h: remove __strncpy_from_user/__strnlen_user Arnd Bergmann
2021-05-17 7:42 ` Geert Uytterhoeven
2021-05-17 8:42 ` Arnd Bergmann
2021-05-14 22:09 ` [PATCH 2/5] hexagon: use generic strncpy/strnlen from_user Arnd Bergmann
2021-05-14 22:09 ` [PATCH 3/5] arc: " Arnd Bergmann
2021-05-14 22:09 ` [PATCH 4/5] asm-generic: uaccess: remove inline strncpy_from_user/strnlen_user Arnd Bergmann
2021-05-17 7:49 ` Geert Uytterhoeven
2021-05-14 22:09 ` [PATCH 5/5] asm-generic: remove extra strn{cpy_from,len}_user declarations Arnd Bergmann
2021-05-15 6:40 ` [PATCH 0/5] asm-generic: strncpy_from_user/strnlen_user cleanup Christoph Hellwig
2021-05-15 9:55 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a2ukLgV3K3sW8gkkz6cvKh+wmP_C0av2hnYcftfXMPTWA@mail.gmail.com \
--to=arnd@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=anton.ivanov@cambridgegreys.com \
--cc=aou@eecs.berkeley.edu \
--cc=bcain@codeaurora.org \
--cc=geert@linux-m68k.org \
--cc=hch@lst.de \
--cc=jdike@addtoit.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux-um@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=richard@nod.at \
--cc=rppt@kernel.org \
--cc=sidneym@codeaurora.org \
--cc=uclinux-h8-devel@lists.sourceforge.jp \
--cc=vgupta@synopsys.com \
--cc=viro@zeniv.linux.org.uk \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).