From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932306AbeAXIH2 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 24 Jan 2018 03:07:28 -0500
Received: from mail-oi0-f67.google.com ([209.85.218.67]:46446 "EHLO
        mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752375AbeAXIH1 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 24 Jan 2018 03:07:27 -0500
X-Google-Smtp-Source: AH8x224m/pzxI5VPiwXiYJWfwW1hM8rNeM37Cg94wOs6RFNVszNSqzvosKQqC9/pYPDkLNMeiPvXsueID0tnzxDQE1c=
MIME-Version: 1.0
In-Reply-To: <20180124074845.32125-1-fancer.lancer@gmail.com>
References: <20180119173044.8013-1-fancer.lancer@gmail.com> <20180124074845.32125-1-fancer.lancer@gmail.com>
From: Arnd Bergmann <arnd@arndb.de>
Date: Wed, 24 Jan 2018 09:07:26 +0100
X-Google-Sender-Auth: Bsqm2OXJxa5fgqkyTNwyIAlazTE
Message-ID: <CAK8P3a2vp1U1i9-b1vX_FEs-_DGvWx-ut+Z_5hk4R_CxUNiucg@mail.gmail.com>
Subject: Re: [PATCH v2] NTB: ntb_perf: fix cast to restricted __le32
To: Serge Semin <fancer.lancer@gmail.com>
Cc: jdmason@kudzu.us, Dave Jiang <dave.jiang@intel.com>, allenbh@gmail.com,
        "Hook, Gary" <gary.hook@amd.com>, Sergey.Semin@t-platforms.ru,
        linux-ntb@googlegroups.com,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 24, 2018 at 8:48 AM, Serge Semin <fancer.lancer@gmail.com> wrote:
> Sparse is whining about the u32 and __le32 mixed usage in the driver
>
> drivers/ntb/test/ntb_perf.c:288:21: warning: cast to restricted __le32
> drivers/ntb/test/ntb_perf.c:295:37: warning: incorrect type in argument 4 (different base types)
> drivers/ntb/test/ntb_perf.c:295:37:    expected unsigned int [unsigned] [usertype] val
> drivers/ntb/test/ntb_perf.c:295:37:    got restricted __le32 [usertype] <noident>
> ...
>
> NTB hardware drivers shall accept CPU-endian data and translate it to
> the portable formate by internal means, so the explicit conversions
> are not necessary before Scratchpad/Messages API usage anymore.
>
> Fixes: b83003b3fdc1 ("NTB: ntb_perf: Add full multi-port NTB API support")
> Signed-off-by: Serge Semin <fancer.lancer@gmail.com>

Looks good to me,

Acked-by: Arnd Bergmann <arnd@arndb.de>