From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753262AbdHBLpL (ORCPT ); Wed, 2 Aug 2017 07:45:11 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:35933 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752305AbdHBLpJ (ORCPT ); Wed, 2 Aug 2017 07:45:09 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170802093722.3666961-1-arnd@arndb.de> <20170802100124.bcr3ux6bt4hnlu6r@phenom.ffwll.local> From: Arnd Bergmann Date: Wed, 2 Aug 2017 13:45:07 +0200 X-Google-Sender-Auth: gwryqjlnFRoyVJLjgskyugkZ3Pg Message-ID: Subject: Re: [PATCH] fbdev: matrox: hide unused 'hotplug' variable To: Arvind Yadav Cc: Bartlomiej Zolnierkiewicz , Dan Carpenter , Sean Paul , linux-fbdev@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v72BjFCt015143 On Wed, Aug 2, 2017 at 1:14 PM, Arvind Yadav wrote: > Hi Arnd, > > With is change we can get below error. If MODULE is define. > > drivers/video/fbdev/matrox/matroxfb_base.c: In function ‘initMatrox2’: > drivers/video/fbdev/matrox/matroxfb_base.c:1799:23: error: ‘hotplug’ > undeclared (first use in this function) > minfo->fbcon.flags = hotplug ? FBINFO_FLAG_MODULE : FBINFO_FLAG_DEFAULT; > > Please check this. I think you are looking at an older tree, the patch only applies to today's fbdev/fbdev-for-next branch, containing commit 376b3ff54c9a ("fbdev: Nuke FBINFO_MODULE"), which was applied last night. Arnd