From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <arndbergmann@gmail.com>
ARC-Seal: i=1; a=rsa-sha256; t=1516877496; cv=none;
        d=google.com; s=arc-20160816;
        b=CMzce+/asec43ZKEOURrO9VYXTJuQ2Bv4/E642yMsbXgxykHiEOUrCh9CZnU+rRTnz
         abNBpW8X2MnQvXHm+C5rIy9AiWRTxAPD72uaQDG9QCl9g0x3Dl/E8zOPhPpPSiEa1z2h
         AQSekdqYO8CgYgyH/P1iwXDYKVWPhZcAqdgD3WRi09EQIPtm9A1N+Lnk8h/B0LPKTivA
         e32g1bU3V79xU2HnQEo8Mc0ynVgeS5zqwCYrlBI3ffqg1vqRewFu+3Rh4MwF5R665/IC
         hTY7lkSVCugk2w0lraxB+msVWk8WsiPsW7xDsTNyCMhD0pGnEJ4QKPegL+EDSp7MgjAI
         Gz4A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=cc:to:subject:message-id:date:from:references:in-reply-to:sender
         :mime-version:dkim-signature:arc-authentication-results;
        bh=3Cpr3Zmrg63vyJ5clTXv7/HTJiMf3YyyhteMl5dJNCg=;
        b=gE81W09lyqUgcwiyof/aSKb9T5wrEPhSvi5TINAi+wb/uKHqr4YxG/zS85a7sxCRtO
         SqPS2G5McY0XCforRGuglqgopGrkkk8XTp35pKB5dugIrCgHSx0SvqE/PIVeHUBpItp1
         4B8Nw8p60VBts0rorzvFd8GcZHq6LoNfEMKVaxRpK/qAWVrEC1lMBCaY3OjfMmVC4r1h
         fU+QMv08ow+CLEG6hBe66gzxQ/btdaXtClGpwonHXmQH+8WA73L40lWrisgvYVNBClg1
         7Av0avfipI9SNQvAKPJhQhWHOj/AFJ9OShToaZWxObojPZXVk+N9vIsLc39eGOnt4Ure
         2v7g==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@gmail.com header.s=20161025 header.b=l5xcgfE2;
       spf=pass (google.com: domain of arndbergmann@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=arndbergmann@gmail.com
Authentication-Results: mx.google.com;
       dkim=pass header.i=@gmail.com header.s=20161025 header.b=l5xcgfE2;
       spf=pass (google.com: domain of arndbergmann@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=arndbergmann@gmail.com
X-Google-Smtp-Source: AH8x224+z1Jn5/gpteKE5RIr/RfQ67eszheibhvOuUs142oeYx3HFuC3Gdni9+VEy36ruD/zkTkKfG0y1bvR24W8EV4=
MIME-Version: 1.0
Sender: arndbergmann@gmail.com
In-Reply-To: <20180124004340.GA25212@embeddedgus>
References: <20180124004340.GA25212@embeddedgus>
From: Arnd Bergmann <arnd@arndb.de>
Date: Thu, 25 Jan 2018 11:51:34 +0100
X-Google-Sender-Auth: 8dvLz8Q5Lv3zDp0ZkQhAUiJzU3Q
Message-ID: <CAK8P3a3-Cx0Az9d6rpVUA4dRtCH7kghS65MOEGp0zd5tyU2FFQ@mail.gmail.com>
Subject: Re: [PATCH] staging: imx-media-vdic: fix inconsistent IS_ERR and PTR_ERR
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Steve Longerbeam <slongerbeam@gmail.com>, Philipp Zabel <p.zabel@pengutronix.de>,
	Mauro Carvalho Chehab <mchehab@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linux Media Mailing List <linux-media@vger.kernel.org>, devel@driverdev.osuosl.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Content-Type: text/plain; charset="UTF-8"
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: =?utf-8?q?1590432494114663836?=
X-GMAIL-MSGID: =?utf-8?q?1590561337510395367?=
X-Mailing-List: linux-kernel@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>

On Wed, Jan 24, 2018 at 1:43 AM, Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
> Fix inconsistent IS_ERR and PTR_ERR in vdic_get_ipu_resources.
> The proper pointer to be passed as argument is ch.
>
> This issue was detected with the help of Coccinelle.
>
> Fixes: 0b2e9e7947e7 ("media: staging/imx: remove confusing IS_ERR_OR_NULL usage")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

good catch!

Acked-by: Arnd Bergmann <arnd@arndb.de>