From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C82AC433DB for ; Wed, 10 Mar 2021 11:26:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B853E64E21 for ; Wed, 10 Mar 2021 11:26:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232693AbhCJL0G (ORCPT ); Wed, 10 Mar 2021 06:26:06 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:57427 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231161AbhCJLYR (ORCPT ); Wed, 10 Mar 2021 06:24:17 -0500 Received: from mail-ot1-f44.google.com ([209.85.210.44]) by mrelayeu.kundenserver.de (mreue107 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MGQzj-1lWIM71eAv-00GoSe; Wed, 10 Mar 2021 12:23:58 +0100 Received: by mail-ot1-f44.google.com with SMTP id x28so1271357otr.6; Wed, 10 Mar 2021 03:23:57 -0800 (PST) X-Gm-Message-State: AOAM5339D7e95cwCcbZPCPbhyGrW/LOC6RZj7tAtqETACXCOPzqrqI1m xbSoXNOvqgctYIV2tXq7t5Su2RBmFhIoZjimzWQ= X-Google-Smtp-Source: ABdhPJzSi9rQjVmQMcCdC3Ugc0EWFLl//ABE/fGqmyUE3BjBZcH2sAsjResUueB/qNZ0M5JXaPsoktuZzqJxAH31rsg= X-Received: by 2002:a05:6830:14c1:: with SMTP id t1mr2167623otq.305.1615375436800; Wed, 10 Mar 2021 03:23:56 -0800 (PST) MIME-Version: 1.0 References: <20210309181533.231573-1-willy@infradead.org> In-Reply-To: <20210309181533.231573-1-willy@infradead.org> From: Arnd Bergmann Date: Wed, 10 Mar 2021 12:23:40 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] include: Remove pagemap.h from blkdev.h To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , Linux-MM , "linux-kernel@vger.kernel.org" , linux-block , linux-bcache@vger.kernel.org, linux-nvdimm@lists.01.org, linux-scsi Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:ZAMdrLCRoCgXj3tTGCPDyaMO7QGvyKUlz2EHeBiucgYdBifB9nF PJ5b8WT7SWsdRy9ivuV9503hX0xNnHrYgtkQG+PUtIjdN7esmNers6qgqNOvGDJt6zuueb5 Nq7v3rBHycipdjqcDt3ptbbJG1hsm+6sql36pHv7Gaa8pgd4Wmj6JdvCw5SQl95Q2/XoZUa L1ofXYif4PmcgUrbOclWA== X-UI-Out-Filterresults: notjunk:1;V03:K0:3jyXK99JXM8=:VDoDom1E04Ct8FnIHdWHkg 5Ia4vX9kWptKMWFI2zdlhOS1L40FOH7iyhTCZoJ12kCJjOgrNQdrwxevWz9IJdReQ2UPTUEEd u3ZSsc8A/wAcv+XSW3uWZnntuFRWkAKHeF6hyKb8IFFjB660n3gFDfehLH2DsRe2GGLGHdkUq tUggdFAmLCPZ/cPV7Dsnq8wm4zjBU1AGlsmPPS7s7s4WJ09528pUivexpAe/l+2suGTdRc8Av FQ8i5bNuYbMs4xeIzFWCoiKGQyOEu2t9yHO+fboZRlz+z4nm6Rnpke7/WkHyKb0+czrBigcrl 5dBXq0rJjNDeLX6laLu8FzJbqjR0qvXblJbXqp7LkN5O5Gi8s8Nogx8UG7A+o0MygmDU8yy6N hK1kWDOapsDkcd2Ol+yrD3zFXsBclF/RIkBI5EXZKHDKJH1RpZRPqZnPnVd9K69dvIDPRhIbu ifERUrrchHyrdg681fLrJet4UnLg+kd7yKddq1Z4quovkXRUimZ8plkiW/VZ+kslZVCUt7HWP vBSRcO+OX30XqqSlcFpYHCzjkmhBE13iYDgWeFCGaWPraJY0vCQ5dwHYlf4m2Qwug== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 9, 2021 at 7:15 PM Matthew Wilcox (Oracle) wrote: > > My UEK-derived config has 1030 files depending on pagemap.h before > this change. Afterwards, just 240 files need to be rebuilt when I > touch pagemap.h. I think blkdev.h is probably included too widely, > but untangling that dependency is harder and this solves my problem. > x86 allmodconfig builds, but there may be implicit include problems > on other architectures. > > Signed-off-by: Matthew Wilcox (Oracle) Good catch! With the build regression fixed (I suppose you now need to include pagemap.h in swap.h): Acked-by: Arnd Bergmann