From: Arnd Bergmann <arnd@arndb.de>
To: "Shenhar, Talel" <talel@amazon.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
David Miller <davem@davemloft.net>,
gregkh <gregkh@linuxfoundation.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Thomas Gleixner <tglx@linutronix.de>,
Patrick Venture <venture@google.com>,
Linus Walleij <linus.walleij@linaro.org>,
Olof Johansson <olof@lixom.net>,
Maxime Ripard <mripard@kernel.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
paul.kocialkowski@bootlin.com, mjourdan@baylibre.com,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, DTML <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
David Woodhouse <dwmw@amazon.co.uk>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
hhhawa@amazon.com, ronenk@amazon.com, jonnyc@amazon.com,
hanochu@amazon.com, barakw@amazon.com
Subject: Re: [PATCH 3/3] arm64: alpine: select AL_POS
Date: Mon, 9 Sep 2019 15:45:18 +0200 [thread overview]
Message-ID: <CAK8P3a34eKFXoAPOfkFN5+H4kxOhRjXgws_0wy+d-186LFxcTw@mail.gmail.com> (raw)
In-Reply-To: <ab512ced-d989-5c10-a550-2a4723d38e7e@amazon.com>
On Mon, Sep 9, 2019 at 12:17 PM Shenhar, Talel <talel@amazon.com> wrote:
> On 9/9/2019 12:40 PM, Arnd Bergmann wrote:
> > On Mon, Sep 9, 2019 at 11:14 AM Talel Shenhar <talel@amazon.com> wrote:
> >> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> >> index 4778c77..bd86b15 100644
> >> --- a/arch/arm64/Kconfig.platforms
> >> +++ b/arch/arm64/Kconfig.platforms
> >> @@ -25,6 +25,7 @@ config ARCH_SUNXI
> >> config ARCH_ALPINE
> >> bool "Annapurna Labs Alpine platform"
> >> select ALPINE_MSI if PCI
> >> + select AL_POS
> >> help
> >> This enables support for the Annapurna Labs Alpine
> >> Soc family.
> > Generally I think this kind of thing should go into the defconfig
> > rather than being hard-selected. There might be users that
> > want to not enable the driver.
>
> The reason for selecting it is because this is a driver that we will
> always want for ARCH_ALPINE.
Can you put the exact requirement (other than "we want this")
in the changelog text then? It's still not clear to me what breaks
without this driver.
Arnd
next prev parent reply other threads:[~2019-09-09 13:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 9:10 [PATCH 0/3] Amazon's Annapurna Labs POS Driver Talel Shenhar
2019-09-09 9:10 ` [PATCH 1/3] dt-bindings: soc: al-pos: Amazon's Annapurna Labs POS Talel Shenhar
2019-09-09 9:10 ` [PATCH 2/3] soc: amazon: al-pos: Introduce Amazon's Annapurna Labs POS driver Talel Shenhar
2019-09-09 9:44 ` Arnd Bergmann
2019-09-09 11:12 ` Shenhar, Talel
2019-09-09 13:41 ` Arnd Bergmann
2019-09-09 14:11 ` Shenhar, Talel
2019-09-09 15:16 ` Arnd Bergmann
2019-09-10 6:21 ` Shenhar, Talel
2019-09-09 11:51 ` kbuild test robot
2019-09-09 9:10 ` [PATCH 3/3] arm64: alpine: select AL_POS Talel Shenhar
2019-09-09 9:40 ` Arnd Bergmann
2019-09-09 10:16 ` Shenhar, Talel
2019-09-09 13:45 ` Arnd Bergmann [this message]
2019-09-09 13:58 ` Shenhar, Talel
2019-09-09 15:08 ` Arnd Bergmann
2019-09-10 6:17 ` Shenhar, Talel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a34eKFXoAPOfkFN5+H4kxOhRjXgws_0wy+d-186LFxcTw@mail.gmail.com \
--to=arnd@arndb.de \
--cc=barakw@amazon.com \
--cc=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dwmw@amazon.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=jonnyc@amazon.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab+samsung@kernel.org \
--cc=mjourdan@baylibre.com \
--cc=mripard@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=olof@lixom.net \
--cc=paul.kocialkowski@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=ronenk@amazon.com \
--cc=ssantosh@kernel.org \
--cc=talel@amazon.com \
--cc=tglx@linutronix.de \
--cc=venture@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).