From: Arnd Bergmann <arnd@arndb.de>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>, Paul Fulghum <paulkf@microgate.com>,
"linux-kernel@vger.kernel.org Mailing List"
<linux-kernel@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
syzbot <syzbot+c244af085a0159d22879@syzkaller.appspotmail.com>,
syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] tty/n_hdlc: fix __might_sleep warning
Date: Thu, 10 Jan 2019 13:25:59 +0100 [thread overview]
Message-ID: <CAK8P3a39t3pDjL9yqS6T9JQM-nGej7gvZibhya5qkC1JDHj5tw@mail.gmail.com> (raw)
In-Reply-To: <d351e662-0087-9cd7-46b2-ef49134c639c@i-love.sakura.ne.jp>
On Thu, Jan 10, 2019 at 12:39 PM Tetsuo Handa
<penguin-kernel@i-love.sakura.ne.jp> wrote:
> On 2019/01/02 5:28, Paul Fulghum wrote:
> > Fix __might_sleep warning in tty/n_hdlc.c read due to copy_to_user call while current is TASK_INTERRUPTIBLE.
> > This is a false positive since the code path does not depend on current state remaining TASK_INTERRUPTIBLE.
> > The loop breaks out and sets TASK_RUNNING after calling copy_to_user.
> > This patch supresses the warning by setting TASK_RUNNING before calling copy_to_user.
> >
> > [1] https://syzkaller.appspot.com/bug?id=17d5de7f1fcab794cb8c40032f893f52de899324
> >
> > Signed-off-by: Paul Fulghum <paulkf@microgate.com>
> > Reported-by: syzbot <syzbot+c244af085a0159d22879@syzkaller.appspotmail.com>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
This version looks good to me.
Acked-by: Arnd Bergmann <arnd@arndb.de>
Arnd
next prev parent reply other threads:[~2019-01-10 12:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-29 0:41 WARNING in __might_sleep (2) syzbot
2018-12-29 11:48 ` [PATCH] tty/n_hdlc: fix sleep in !TASK_RUNNING state warning Tetsuo Handa
2019-01-01 3:13 ` Paul Fulghum
2019-01-01 20:28 ` [PATCH] tty/n_hdlc: fix __might_sleep warning Paul Fulghum
2019-01-10 11:38 ` Tetsuo Handa
2019-01-10 12:25 ` Arnd Bergmann [this message]
[not found] ` <FEBFE826-8D27-4A0B-86A5-BA559921CADC@microgate.com>
2019-01-02 15:04 ` [PATCH] tty/n_hdlc: fix sleep in !TASK_RUNNING state warning Tetsuo Handa
2019-01-02 20:55 ` Paul Fulghum
2019-01-03 9:09 ` Jiri Slaby
2019-01-03 11:32 ` Tetsuo Handa
2019-01-03 15:57 ` Paul Fulghum
2019-01-04 10:23 ` Tetsuo Handa
2019-01-04 13:57 ` Paul Fulghum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a39t3pDjL9yqS6T9JQM-nGej7gvZibhya5qkC1JDHj5tw@mail.gmail.com \
--to=arnd@arndb.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulkf@microgate.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=syzbot+c244af085a0159d22879@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).