From: Arnd Bergmann <arnd@arndb.de>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
Ilia Lin <ilia.lin@kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Amit Kucheria <amit.kucheria@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cpufreq: kyro: Reduce frame-size of qcom_cpufreq_kryo_probe()
Date: Wed, 20 Feb 2019 13:30:38 +0100 [thread overview]
Message-ID: <CAK8P3a3Qkrx75K6sTQqhn0MZmOQ5O6x-FRH_2MkCkZf2OehZfQ@mail.gmail.com> (raw)
In-Reply-To: <5919a74b74f466e803e07f70136517119dcd4560.1550661235.git.viresh.kumar@linaro.org>
On Wed, Feb 20, 2019 at 12:14 PM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> With the introduction of commit 846a415bf440 ("arm64: default NR_CPUS to
> 256"), we have started getting following compilation warning:
>
> qcom-cpufreq-kryo.c:168:1: warning: the frame size of 2160 bytes is larger than 2048 bytes [-Wframe-larger-than=]
>
> Fix that by dynamically allocating opp_tables and freeing it later.
>
> Compile tested only.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Looks good to me, thanks for the fix!
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2019-02-20 12:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 11:14 [PATCH] cpufreq: kyro: Reduce frame-size of qcom_cpufreq_kryo_probe() Viresh Kumar
2019-02-20 12:30 ` Arnd Bergmann [this message]
2019-02-20 16:26 ` Amit Kucheria
2019-02-21 3:45 ` Viresh Kumar
2019-02-21 4:32 ` Amit Kucheria
2019-02-21 4:44 ` Viresh Kumar
2019-02-27 7:52 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a3Qkrx75K6sTQqhn0MZmOQ5O6x-FRH_2MkCkZf2OehZfQ@mail.gmail.com \
--to=arnd@arndb.de \
--cc=amit.kucheria@linaro.org \
--cc=ilia.lin@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).