From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936595AbdCXQQZ (ORCPT ); Fri, 24 Mar 2017 12:16:25 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:34202 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966121AbdCXQNj (ORCPT ); Fri, 24 Mar 2017 12:13:39 -0400 MIME-Version: 1.0 In-Reply-To: <4281f8e01b9fc5628cbf4a5c77abd642801e23c7.1490188942.git.dwmw2@infradead.org> References: <4281f8e01b9fc5628cbf4a5c77abd642801e23c7.1490188942.git.dwmw2@infradead.org> From: Arnd Bergmann Date: Fri, 24 Mar 2017 17:13:36 +0100 X-Google-Sender-Auth: Vh6HGIHk-CjEcBUdiUupgbWkZAA Message-ID: Subject: Re: [PATCH 17/17] arm64: Do not expose PCI mmap through procfs To: David Woodhouse Cc: linux-pci , linux-arch , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 22, 2017 at 2:25 PM, David Woodhouse wrote: > From: David Woodhouse > > Signed-off-by: David Woodhouse > --- > drivers/pci/proc.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/pci/proc.c b/drivers/pci/proc.c > index 2d9cfa4..a940f4b 100644 > --- a/drivers/pci/proc.c > +++ b/drivers/pci/proc.c > @@ -17,6 +17,11 @@ > > static int proc_initialized; /* = 0 */ > > +#ifdef __aarch64__ > +/* ARM64 wants to be special and not expose this through /proc like everyone else */ > +#undef HAVE_PCI_MMAP > +#endif I'd still prefer this to be a whitelist of the existing architectures using PCI MMAP in procfs, there is really no reason for arm64 to be special, the one thing we want to control here is whether new architectures (including arm64) that have never had either the sysfs or the procfs interface should get one or both of them. As it seems that there are important use cases for the sysfs interface and your patch series will just make that work everywhere, I'd argue that we should just always provide the sysfs interface now, and use HAVE_PCI_MMAP only control the procfs interface. That way, we turn on the sysfs interface on arc, arm64, frv and tile as well as any future architecture with PCI support, but leave the procfs support as opt-in. Arnd