From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62B1CC636CA for ; Wed, 21 Jul 2021 18:40:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 385FF61245 for ; Wed, 21 Jul 2021 18:40:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238604AbhGUSAM (ORCPT ); Wed, 21 Jul 2021 14:00:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:37852 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230269AbhGUSAL (ORCPT ); Wed, 21 Jul 2021 14:00:11 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1341F61245; Wed, 21 Jul 2021 18:40:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626892848; bh=fxLeBTcwtMJIq5IP6YeqeOIxzqsNUv8gWvGoGXAJrbY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=PuBf9zUl9zaieOwjHvaSL3SVhSvoN7b/TIy7zskis+GdFB+eTVhcUlp+YO856DlQ1 xiERYgp1Xwg4YZ4Ces+NGVqkm85uCBlnsynF5qiEr/+SzibE2wktMyGg82uDLyhTXE 6CWGZT3YbIrXK3ynRTtPodQnczHPIZupIXt1VaIm+a8oJZfan2c9v7C8B5X/ONNoVV r3tM2dGlUYgeAOfbusiswOarEFKLmRRiooz7K9eCSXVYpJxYKM8FhntzV2QV9EAksc 82teJ11dGhgiMOQSl9xLWJMj6OipTHP4BghDfZ0roi1SGSmhExu6oFVqImXPtLse9U dlS/lZaP+rlqw== Received: by mail-wm1-f46.google.com with SMTP id u8-20020a7bcb080000b02901e44e9caa2aso1525129wmj.4; Wed, 21 Jul 2021 11:40:47 -0700 (PDT) X-Gm-Message-State: AOAM533FHnZaDZ4d542ZTht9lLjQoFOL/79wkoemE7TQ95rPZg1oj328 b24IztKAiTlJRT7sf0Sg2ww/QmseuGMuDa8z2XM= X-Google-Smtp-Source: ABdhPJyapcX0UTSpkQnyUJxtKZP9YohAvMD132I/yNBSutw/CQX+i9Vgh62dwOdJNBBw/Q6obQMBD9Za3zCC73pL+dc= X-Received: by 2002:a1c:c90f:: with SMTP id f15mr5478526wmb.142.1626892846710; Wed, 21 Jul 2021 11:40:46 -0700 (PDT) MIME-Version: 1.0 References: <20210721151330.2176653-1-arnd@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Wed, 21 Jul 2021 20:40:30 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] iio: accel: fxls8962af: fix i2c dependency To: Andy Shevchenko Cc: Jonathan Cameron , Sean Nyekjaer , Arnd Bergmann , Lars-Peter Clausen , Linus Walleij , Stephan Gerhold , Hans de Goede , Tomas Melin , Mike Looijmans , Alexandru Ardelean , linux-iio@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 21, 2021 at 7:34 PM Andy Shevchenko wrote: > On Wed, Jul 21, 2021 at 7:12 PM Arnd Bergmann wrote: > > On Wed, Jul 21, 2021 at 5:52 PM Andy Shevchenko > > wrote: > > > On Wed, Jul 21, 2021 at 6:13 PM Arnd Bergmann wrote: > > ... > > > > > config FXLS8962AF > > > > tristate > > > > + depends on I2C || !I2C # cannot be built-in for modular I2C > > > > > > Can you enlighten me how this will not be a no-op? > > > > This part does nothing, it only causes a warning when FXLS8962AF > > gets selected =y when I2C=m. > > This is something new to me. But shouldn't the other chunk guarantee > that warning won't happen? Correct, it works without that, but if that fails after something changes, this version would provide better diagnostics than the FXLS8962AF core driver causing a link failure, and I found it documents better why the other driver needs the dependency. Let me know if you prefer me to resend the patch without this hunk. Arnd