Re: [PATCH 6/8] x86: add MULTIUSER dependency for KVM

From: Arnd Bergmann <arnd@arndb.de>
To: "Radim Krčmář" <rkrcmar@redhat.com>
Cc: "the arch/x86 maintainers" <x86@kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>,
	kvm@vger.kernel.org
Subject: Re: [PATCH 6/8] x86: add MULTIUSER dependency for KVM
Date: Wed, 19 Jul 2017 16:18:09 +0200	[thread overview]
Message-ID: <CAK8P3a3SyBmKbcC2BBfhPTVUOpO=oJKJmUKwsFhFXTvm-YSNBg@mail.gmail.com> (raw)
In-Reply-To: <20170719141153.GA17303@potion>

On Wed, Jul 19, 2017 at 4:11 PM, Radim Krčmář <rkrcmar@redhat.com> wrote:
> 2017-07-19 14:53+0200, Arnd Bergmann:
>> KVM tries to select 'TASKSTATS', which had additional dependencies:
>>
>> warning: (KVM) selects TASKSTATS which has unmet direct dependencies (NET && MULTIUSER)
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>
> Hm, do you know why Kconfig warns instead of propagating the
> dependencies?

Kconfig propagates 'depends on' dependencies, but cannot turn a 'select'
into 'depends on', as those two mean different things.

Another solution to the problem would be to use 'depends on TASKSTATS'.

Generally speaking, using 'select' to turn on a user-visible option is a bad
idea, but blindly turning those 'select' into 'depends on' is also dangerous,
as it can break configurations of existing users that would here end up with
neither TASKSTATS nor KVM after a 'make oldconfig'.

      Arnd