From: Arnd Bergmann <arnd@arndb.de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Richard Gong <richard.gong@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Dinh Nguyen <dinguyen@kernel.org>,
kbuild-all@lists.01.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
kernel test robot <lkp@intel.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Jens Wiklander <jens.wiklander@linaro.org>
Subject: Re: [PATCH] firmware: stratix10-svc: build only on 64-bit ARM
Date: Mon, 22 Mar 2021 10:28:53 +0100 [thread overview]
Message-ID: <CAK8P3a3UVqJ+pfFxtKOiTtWUYW+9FBBONz+OwJUamc=N33G8QQ@mail.gmail.com> (raw)
In-Reply-To: <2ae8379f-c79f-3257-e54c-fa17c576e929@canonical.com>
On Mon, Mar 22, 2021 at 9:26 AM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
> On 21/03/2021 22:09, Arnd Bergmann wrote:
>
> The SMC has two calling conventions - SMC32/HVC32 and SMC64/HVC64. The
> Stratix 10 driver uses the 64-bit calling convention (see
> INTEL_SIP_SMC_FAST_CALL_VAL in
> include/linux/firmware/intel/stratix10-smc.h), so it should not run in
> aarch32 (regardless of type of hardware).
>
> I think that my patch limiting the support to 64-bit makes sense.
I see that this is the only driver in the kernel that doesn't support the
32-bit calling conventions though, everything else either uses the the 32-bit
calling conventions unconditionally, or picks the ones matching the
kernel execution state.
If the firmware supports both, it would seem best to change the driver
to work like the other ones and pick the appropriate interface based
on what kernel it's running on.
If the firmware is fundamentally limited to the 64-bit interface, your
patch does seem correct, but I'd suggest explaining that in the
changelog.
Arnd
next prev parent reply other threads:[~2021-03-22 9:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-21 18:46 [PATCH] firmware: stratix10-svc: build only on 64-bit ARM Krzysztof Kozlowski
2021-03-21 21:09 ` Arnd Bergmann
2021-03-22 8:26 ` Krzysztof Kozlowski
2021-03-22 9:28 ` Arnd Bergmann [this message]
2021-03-22 12:58 ` Richard Gong
2021-03-22 12:41 ` Krzysztof Kozlowski
2021-03-22 15:29 ` Richard Gong
2021-03-24 20:33 ` Richard Gong
2021-04-01 15:13 Dinh Nguyen
2021-04-02 14:30 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a3UVqJ+pfFxtKOiTtWUYW+9FBBONz+OwJUamc=N33G8QQ@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=dinguyen@kernel.org \
--cc=jens.wiklander@linaro.org \
--cc=kbuild-all@lists.01.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=richard.gong@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).