From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 707E9C433E0 for ; Wed, 27 May 2020 11:33:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 598B9206DF for ; Wed, 27 May 2020 11:33:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729464AbgE0Ldd (ORCPT ); Wed, 27 May 2020 07:33:33 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:54727 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725964AbgE0Ldb (ORCPT ); Wed, 27 May 2020 07:33:31 -0400 Received: from mail-qt1-f177.google.com ([209.85.160.177]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MwQCb-1imMQ81StB-00sPXK; Wed, 27 May 2020 13:33:29 +0200 Received: by mail-qt1-f177.google.com with SMTP id k22so4043403qtm.6; Wed, 27 May 2020 04:33:28 -0700 (PDT) X-Gm-Message-State: AOAM530RRMcKjDTVH729nVCCqJTL7+y4mrTZI2gvMXtAML0Jweln865p BPoR4XL25KrMIUj9BGo50ZFkWPbBrwnuVqt8+P8= X-Google-Smtp-Source: ABdhPJytr2bjG8wmbrwCUlNw85Yc0YEiejDsr/eUYMM1igF/l+KazWx6+Wav70gPMdZ6TcuTfzx28axhkOZA5yS1Tu0= X-Received: by 2002:ac8:306d:: with SMTP id g42mr3579966qte.18.1590579208037; Wed, 27 May 2020 04:33:28 -0700 (PDT) MIME-Version: 1.0 References: <20200522120700.838-1-brgl@bgdev.pl> <20200522120700.838-7-brgl@bgdev.pl> <20200527073150.GA3384158@ubuntu-s3-xlarge-x86> In-Reply-To: From: Arnd Bergmann Date: Wed, 27 May 2020 13:33:11 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 06/11] net: ethernet: mtk-star-emac: new driver To: Bartosz Golaszewski Cc: Nathan Chancellor , Rob Herring , "David S . Miller" , Matthias Brugger , John Crispin , Sean Wang , Mark Lee , Jakub Kicinski , Fabien Parent , Heiner Kallweit , Edwin Peer , devicetree , Linux Kernel Mailing List , netdev , Linux ARM , "moderated list:ARM/Mediatek SoC..." , Stephane Le Provost , Pedro Tsai , Andrew Perepech , Bartosz Golaszewski , clang-built-linux Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:xLCVZVJKQytAvbA8rvzmUb8CsvyaiYXOseUJ7GWZPaF0uJkBKS3 wZqcGEVmdbEivR6kjmvDMEpd7hO3UFwf62hEQ+pS1DvyODLfVZp/8G/He4Cnk7HWkeFc2EK KTPG4qQZmde2+O+RhbHGrzznk73F6CZZCakNOkhAvU1ck2Am5iStpPT67qoBizpzWjS6UBU HZsRfZeKupTRRySgSMk3A== X-UI-Out-Filterresults: notjunk:1;V03:K0:/X7C0o/PeQs=:y5tIAJrBfNdHDdAaJk2Dm1 s56FsrM0Dn2f3KSRCbiI0+hHHtQuYV28tcE5by+77pNRvotxBThPTWfgU6HOJeZM5/ySqXNbq IXV1xo+ktKJAkGh+Ueb1E/rmvnnnhA68t0BV5bFXayPWlN4a6OavB9f9fi6FN8Pf2SBwKTovC EpTXvD1U6Xm8Pa9llDcXlTnGfMPucgcNdLxfalIQapgDdIKmAoti7B22KR/pERJzvaq+mTqd+ k3AstFS/SJbKtKjU0GlMEejWxa/Svvm0E8aY2a44KVMhODdbiTw+OM0fVZna+GMLbnnweInIw E4/3KVlblW6wPR+aOJHXYUhBw93G8UCrZ0Al2q6heb8FOApRbGs108/j/Ztvgy5Ff9Jz/B+2d 0xTh1O/1keqhjB6Sk+m1nFuxdQ45fZzkpb3sINgZrVE+jG1+MGp+D2b8Qv9FWt/V5nYnr8abs gg788k+bsT7BkWiRr8ihTRprdweND8AQb0ZFmrIIpIp79UYPzYWHXpQ1jbzffNt5e4CyrzS/E F0bPKQzYTOb9YqN23DFwwIuV1odKcJdyIPRpzERiAHYDpRMz/nXzVM4edyqpyMMRRj/4oWRcx /lX45laOFCI3048ND62UOR3EZlq854vatp/rqz375WyBB3ThWSoiiCJ2OPyjAB6SF8nP6RzpH Z7/jdeOqmoJabBdSLsYB8OY/LqTRZrzKdMNqQO//yUDkMfUv6y3G+olNDaBPwXDm2h53FqxtL YPdTzYIdtSK/7eK3nAZmAJEmM/iRjGulLKU18fa2zxoYomAF792s1dak+1ZNJy5KoDdiSgCXK s6H2NMy59a6MFFUm/LW/iG8PijuygUhGGqYpwa4/3O2Wiqy4Yg= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 27, 2020 at 10:46 AM Bartosz Golaszewski wrote: > > I don't know if there should be a new label that excludes that > > assignment for those particular gotos or if new_dma_addr should > > be initialized to something at the top. Please take a look at > > addressing this when you get a chance. > > > > Cheers, > > Nathan > > Hi Nathan, > > Thanks for reporting this! I have a fix ready and will send it shortly. I already have a workaround for this bug as well as another one in my tree that I'll send later today after some more testing. Feel free to wait for that, or just ignore mine if you already have a fix. Arnd