From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F3A0C33CB1 for ; Wed, 15 Jan 2020 10:25:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3870620661 for ; Wed, 15 Jan 2020 10:25:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729752AbgAOKZm (ORCPT ); Wed, 15 Jan 2020 05:25:42 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:38643 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729631AbgAOKZm (ORCPT ); Wed, 15 Jan 2020 05:25:42 -0500 Received: from mail-qt1-f173.google.com ([209.85.160.173]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.145]) with ESMTPSA (Nemesis) id 1Msqty-1jg3X12u40-00t9dl; Wed, 15 Jan 2020 11:25:39 +0100 Received: by mail-qt1-f173.google.com with SMTP id i13so15299053qtr.3; Wed, 15 Jan 2020 02:25:39 -0800 (PST) X-Gm-Message-State: APjAAAUMoawuhGAUQ9MTz8INzejSe+qde0QOIWMaz/uZdZXOV9pghxpe j5FLZZ01KtJw6XJfkEmObjiT9BzxlypNZ6vvLLM= X-Google-Smtp-Source: APXvYqxpuhynJBn4yx21WjIw3nubH1blYL0w6bO48MGvf28mqDOMWLqUGKBHq3Rnw96u8X2M6HN66y7y478g7fpYmxs= X-Received: by 2002:ac8:6153:: with SMTP id d19mr2754011qtm.18.1579083938582; Wed, 15 Jan 2020 02:25:38 -0800 (PST) MIME-Version: 1.0 References: <20200115082447.19520-1-namjae.jeon@samsung.com> <20200115082447.19520-4-namjae.jeon@samsung.com> In-Reply-To: <20200115082447.19520-4-namjae.jeon@samsung.com> From: Arnd Bergmann Date: Wed, 15 Jan 2020 11:25:22 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v10 03/14] exfat: add inode operations To: Namjae Jeon Cc: "linux-kernel@vger.kernel.org" , Linux FS-devel Mailing List , gregkh , Valdis Kletnieks , Christoph Hellwig , sj1557.seo@samsung.com, linkinjeon@gmail.com, =?UTF-8?Q?Pali_Roh=C3=A1r?= Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:qQ16a62MJXwG16nVvWgdenECLmibZogu1QKYOCn6yF7WN+F64A7 oCfznoFSDHUQvAI2cT+b49ziPDKC7yH4BJp1fLtx4FW38znBzVNXFaTjzc3fIGp4/3T09UA l5UwAcMCip1wMuWMh+QvJUvw7xdJtjB2H5K+7P/QgGeWA+R+BiPXKty5zTEKrV/cqHvC8H+ UtdHaTpbbDTlIY/U/KY2g== X-UI-Out-Filterresults: notjunk:1;V03:K0:1WCkLNSHsGA=:fD2fqRZjniq/nEdkNJ6ajr b6/SpojxTHCCkIcJcnotza/iA3JSeUndTVdUF5eL6uGAW7NhLGr3U7RPhglGfP6nMhkVvsJmS 785WSlpW1EV8rcU0sxp1soJsTo0nW39KHsU3H1CiYQjc/7JNAB9MQS1duPHX/C6CU6nRTLiHU be2o9p/Qky1zdjqLPQrqcATBBDE+IYd1S9V/mKDMDa2x+wf7Ez4PwazBqyuD0JMdn2+WEEF/1 aWJ2KMl7xEtVgg6tscayjMLQ9/HTdDEUDRicnEvvyyoizNN24yGvQGqO8190SB4npt0IKL/GL GBXiIDonJJ77eFx1OA3wtVwNALQsfGmFLbMKvJaqtduL0YQE6Xg6yOgIq4FsUtdnU8Lp8j/uG K2uzjxnGtNYmwoQdvoIbklwefGSNbBPA1RTFSyIy83VOsnAojOVpjbkfvy5vOhBOqfb8p97cu u0nxPXlwuoICXkBEdyleFDrpKZN6WSJHMcf8ZsyzwOCANPwIrnaTdAcnli6kuH/9dbva7smTC aZKNn0WRTRmu7z7d5sZ3iIRz7p2vBpIHDiLtbBIroLLT/hDoU/H56cSPkMrGZxI/mUkcmR8K7 6Ahg+WjPL0crdsi9USLeIjn0jjrzRudpcBiRtNJPEpnwbefyHZyHxPZxUcQSHUIpx0h8ZS6eW sWsBAEqQ5vWQkKjYdY1a0kx1oe0Wgfgyd+Xmpy55z/GXzTBuk6yydxDm8lHF+NI2hx9SRnLgB zG/onPjPm1tXug3x26LALOl0XlQub3MaIe80RUuAzgiUxQ647sqJb628yCroj8qrwe+bYqiyn +f0BIAwT4kUaTXl4J1NRSWkjiKjhB9ZvWVJ2sXsV5VElVFz0PD42AL2I/F3MKfpj3672Qgc+X Zug/MC75cp6m73vTr2Qw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 15, 2020 at 9:28 AM Namjae Jeon wrote: > + /* set FILE_INFO structure using the acquired struct exfat_dentry */ > + exfat_set_entry_time(sbi, &inode->i_ctime, > + &ep->dentry.file.create_time, > + &ep->dentry.file.create_date, > + &ep->dentry.file.create_tz); > + exfat_set_entry_time(sbi, &inode->i_mtime, > + &ep->dentry.file.modify_time, > + &ep->dentry.file.modify_date, > + &ep->dentry.file.modify_tz); > + exfat_set_entry_time(sbi, &inode->i_atime, > + &ep->dentry.file.access_time, > + &ep->dentry.file.access_date, > + &ep->dentry.file.access_tz); I wonder if i_ctime should be handled differently. With statx() we finally have a concept of "file creation time" in "stx_btime". so it would make sense to store dentry.file.create_time in there rather than in i_ctime. It seems that traditionally most file systems that cannot store ctime separately just set i_ctime and i_mtime both to what is is modify_time here, though fat and hpfs use i_ctime to refer to creation time. Arnd