From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754105AbdKIKUz (ORCPT ); Thu, 9 Nov 2017 05:20:55 -0500 Received: from mail-oi0-f65.google.com ([209.85.218.65]:47587 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751151AbdKIKUu (ORCPT ); Thu, 9 Nov 2017 05:20:50 -0500 X-Google-Smtp-Source: ABhQp+TcuKwUaKmi+73nIKpqLwu8FMgIVLh7QG1QjY8mfxtlvpoVQF2mJj+BAClYk1nrj+/Ac6kJNQB48smCmzvw1eU= MIME-Version: 1.0 In-Reply-To: References: <805f8432979e2707fbc9bf62dc52b8abfbd2cb14.1510118606.git.green.hu@gmail.com> From: Arnd Bergmann Date: Thu, 9 Nov 2017 11:20:49 +0100 X-Google-Sender-Auth: Ikk401csCHxCiv3JfGGYrRcCeLM Message-ID: Subject: Re: [PATCH 25/31] nds32: defconfig To: Greentime Hu Cc: Greentime , Linux Kernel Mailing List , linux-arch , Thomas Gleixner , Jason Cooper , Marc Zyngier , Rob Herring , Networking , Vincent Chen , deanbo422@gmail.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 9, 2017 at 9:00 AM, Greentime Hu wrote: > 2017-11-08 18:03 GMT+08:00 Arnd Bergmann : >> On Wed, Nov 8, 2017 at 6:55 AM, Greentime Hu wrote: >>> From: Greentime Hu >>> >>> Signed-off-by: Vincent Chen >>> Signed-off-by: Greentime Hu >>> --- >>> arch/nds32/configs/ae3xx_defconfig | 110 +++++++++++++++++++++++++++++++++++ >>> arch/nds32/configs/ag101p_defconfig | 109 ++++++++++++++++++++++++++++++++++ >> >> Are those two incompatible? I would recommend starting without board >> specific defconfig >> files, it just gets messy once you get more than a few machines you >> want to support. > > Thanks. > These 2 are incompatible. > They use different drivers. I may still keep these 2 defconfigs. Using different drivers doesn't make machines incompatible. For instance, the x86 desktop machine has drivers for all kinds of devices, but it uses one configuration that works on basically any x86 machine. Similarly, we only have one defconfig file on arm64, and it works across very diverse machines (phone, home routers, large servers, etc.). All drivers should be written in a way to allow being built into the kernel without doing any harm when you don't have the respective hardware. >>> +CONFIG_FB=y >>> +# CONFIG_VGA_CONSOLE is not set >>> +CONFIG_FRAMEBUFFER_CONSOLE=y >> >> You have a framebuffer console here, but no framebuffer driver? > > Thanks. > I shall enable it when I push our framebuffer in the next time. > I will disable it in the next version patch. The fbdev subsystem is no longer recommended for new drivers, they should be written on top of the DRM framework. You can use CONFIG_DRM_FBDEV_EMULATION to get the framebuffer console on top of that, but then you don't need to enable CONFIG_FB. Please have a look at drivers/gpu/drm/tinydrm/ to see if you can either use that directly, or take it as a skeleton for your own driver. Arnd