From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A19EC432BE for ; Mon, 26 Jul 2021 21:20:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 414B460F91 for ; Mon, 26 Jul 2021 21:20:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233521AbhGZUkG (ORCPT ); Mon, 26 Jul 2021 16:40:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:37002 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232788AbhGZUkD (ORCPT ); Mon, 26 Jul 2021 16:40:03 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8AC5160F9D; Mon, 26 Jul 2021 21:20:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627334431; bh=N9/OEgtjGYplEYJ/2SOff1RZYBM03Kyk8wRDdt0TzFc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=YZSz8zAjEKWKGI4CNnl01LcN2CPppamcN98FCWIlsp5JgD5xRuZeNoK7drOJnNjkT En59u7HuKtdBwJBGMjA5g4ipvOX+8OOAORgfE1CKxHjTZSZ6q/bE2r338oDnjrHp/O 0UtnnrjNQyUD6yXGVIiawJybgIvB9M1VfiuvZPz/EhzeNr/lStgTMjlBwBEd6SOazD 6me1WH9inpfA9BC0DbwFGWoxwo6/YGHA6rdUN0pdKd7W23vjJm89Zg9D+uxci7P203 +WOyr9YM3XP92Mkp2gUfhmJC308zfhFZZIs58aggP0DIzP+TPnmRU/IkI7ZsE83fa9 t+kPQJ7Fsqa/g== Received: by mail-wm1-f45.google.com with SMTP id n21so6187171wmq.5; Mon, 26 Jul 2021 14:20:31 -0700 (PDT) X-Gm-Message-State: AOAM531alCQQXk6JunS/qLYhAiu9yVq/VCrNOIIKgr6R550Byk/ZccfM phP+vRnS3rsam91BUZBWseHYE1gBZ1TPMbSyegQ= X-Google-Smtp-Source: ABdhPJxecW5jkR7LfzmXR3zNuQcz/90Y46z/6ABGm60QvcrorfMTOoQ5aTUp9zNbHSyx4J61jVUQYG6gdWvN8OjB3CI= X-Received: by 2002:a7b:ce10:: with SMTP id m16mr787071wmc.75.1627334430138; Mon, 26 Jul 2021 14:20:30 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Arnd Bergmann Date: Mon, 26 Jul 2021 23:20:13 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V3 1/5] dt-bindings: virtio: Add binding for virtio devices To: Rob Herring Cc: Viresh Kumar , Jason Wang , "Michael S. Tsirkin" , Jean-Philippe Brucker , Vincent Guittot , Bill Mills , =?UTF-8?B?QWxleCBCZW5uw6ll?= , "Enrico Weigelt, metux IT consult" , Jie Deng , DTML , "linux-kernel@vger.kernel.org" , "open list:DRM DRIVER FOR QEMU'S CIRRUS DEVICE" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 26, 2021 at 10:37 PM Rob Herring wrote: > > On Mon, Jul 26, 2021 at 9:54 AM Arnd Bergmann wrote: > > > > On Mon, Jul 26, 2021 at 4:57 PM Rob Herring wrote: > > > On Sun, Jul 25, 2021 at 10:52 PM Viresh Kumar wrote: > > > > + description: | > > > > + Exactly one node describing the virtio device. The name of the node isn't > > > > + significant but its phandle can be used to by a user of the virtio device. > > > > + > > > > + compatible: > > > > + pattern: "^virtio,[0-9a-f]+$" > > > > > > DID is only 4 chars? If so, "^virtio,[0-9a-f]{1,4}$" > > > > Any opinion on whether this should have any namespace prefix (or infix, I guess) > > after "virtio,"? > > > > I previously suggested making it "virtio,device[0-9a-f]{1,4}$", which would > > make it clearer that the following digits are the device ID rather > > than something > > else we might define in the future. Viresh picked this version because it's > > somewhat more consistent with other subsystems. > > I'm fine either way, though I do find just a number a bit strange. So > I'd lean toward adding 'device' or even just a 'd'. I don't think just 'd' would be a good idea since it is indistinguishable from a hexadecimal character. 'dev' would work though. > BTW, what happens if/when the device protocol is rev'ed? A new DID or > is there a separate revision that's discoverable? This should normally be done using feature bits that are negotiated between the two sides, and if only one side can do it, they use the old revision. There could be a new device ID but I don't think that has happened so far. Arnd