From: Arnd Bergmann <arnd@kernel.org>
To: Alexandre Courbot <acourbot@chromium.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Yunfei Dong <yunfei.dong@mediatek.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Tiffany Lin <tiffany.lin@mediatek.com>,
Arnd Bergmann <arnd@arndb.de>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Krzysztof Kozlowski <krzk@kernel.org>,
Helen Koike <helen.koike@collabora.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: mtk-vcodec: add remoteproc dependency
Date: Fri, 4 Dec 2020 16:41:35 +0100 [thread overview]
Message-ID: <CAK8P3a3e+22WiJuV6APJ+vRZjPsbZw+=recE2dje_gjtfQ3gWA@mail.gmail.com> (raw)
In-Reply-To: <CAPBb6MUNsoQ76hi618G6i0djBoRzVvYKkTd8PovNQRacZ06LWA@mail.gmail.com>
On Fri, Dec 4, 2020 at 9:26 AM Alexandre Courbot <acourbot@chromium.org> wrote:
>
> On Fri, Dec 4, 2020 at 8:15 AM Arnd Bergmann <arnd@kernel.org> wrote:
> >
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > The SCP firmware can only be built if CONFIG_REMOTEPROC is
> > enabled:
> >
> > WARNING: unmet direct dependencies detected for MTK_SCP
> > Depends on [n]: REMOTEPROC [=n] && (ARCH_MEDIATEK [=y] || COMPILE_TEST [=y])
> > Selected by [y]:
> > - VIDEO_MEDIATEK_VCODEC [=y] && MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y] && V4L_MEM2MEM_DRIVERS [=y] && (MTK_IOMMU [=y] || COMPILE_TEST [=y]) && VIDEO_DEV [=y] && VIDEO_V4L2 [=y] && (ARCH_MEDIATEK [=y] || COMPILE_TEST [=y])
>
> Despite setting these same options I cannot reproduce this warning on
> a merge of master + media. Which tree are you using?
Sorry about the noise. I was testing this on earlier this week on v5.10-rc5,
but your commit 2da185d6fe96 ("media: mtk-vcodec: fix build breakage
when one of VPU or SCP is enabled") has made it into mainline in the
meantime and fixed the issue.
I had rebased my patches onto linux-next before sending them out to
make sure everything still works, but did not check that it was still
broken without it. Clearly my patch must have conflicted with yours
during the rebase, which should have told me to recheck.
Please disregard my fix.
Arnd
prev parent reply other threads:[~2020-12-04 15:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 23:14 [PATCH] media: mtk-vcodec: add remoteproc dependency Arnd Bergmann
2020-12-04 8:26 ` Alexandre Courbot
2020-12-04 15:41 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a3e+22WiJuV6APJ+vRZjPsbZw+=recE2dje_gjtfQ3gWA@mail.gmail.com' \
--to=arnd@kernel.org \
--cc=acourbot@chromium.org \
--cc=arnd@arndb.de \
--cc=helen.koike@collabora.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jernej.skrabec@siol.net \
--cc=krzk@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=tiffany.lin@mediatek.com \
--cc=yunfei.dong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).