From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933412AbdC3LEo (ORCPT ); Thu, 30 Mar 2017 07:04:44 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:36730 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932541AbdC3LEm (ORCPT ); Thu, 30 Mar 2017 07:04:42 -0400 MIME-Version: 1.0 In-Reply-To: References: <1485894263-91051-1-git-send-email-keescook@chromium.org> <1485894263-91051-2-git-send-email-keescook@chromium.org> From: Arnd Bergmann Date: Thu, 30 Mar 2017 13:04:40 +0200 X-Google-Sender-Auth: moxDxMRh3E8d7KHk59JmJpQ892Y Message-ID: Subject: Re: [PATCH v5 1/4] gcc-plugins: Add the initify gcc plugin To: Kees Cook Cc: Linux Kernel Mailing List , Emese Revfy , Josh Triplett , PaX Team , Masahiro Yamada , minipli@ld-linux.so, Russell King - ARM Linux , Catalin Marinas , Rasmus Villemoes , David Brown , Benjamin Herrenschmidt , Thomas Gleixner , Andrew Morton , Jeff Layton , Sam Ravnborg , kernel-hardening@lists.openwall.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 29, 2017 at 10:56 AM, Arnd Bergmann wrote: > And here is a workaround that I applied locally to avoid the ICE, but > I wouldn't want to have this upstream. > > commit 8712fd8979a5730318a84922fbcb8791ea5af40e > Author: Arnd Bergmann > Date: Wed Mar 29 10:53:48 2017 +0200 > > work around initify ICE > > arch/arm/mach-mv78xx0/common.i: In function 'mv78xx0_init': > arch/arm/mach-mv78xx0/common.i:28:38: internal compiler error: in > search_constant_strings, at > git/arm-soc/scripts/gcc-plugins/initify_plugin.c:1375 > __attribute__ ((latent_entropy)) mv78xx0_init(void) > ^~~~~~~~~~~~ > 0x7fe5cd711b9d search_constant_strings > /git/arm-soc/scripts/gcc-plugins/initify_plugin.c:1375 > 0x7fe5cd711950 search_constant_strings > /git/arm-soc/scripts/gcc-plugins/initify_plugin.c:1335 > 0x7fe5cd711950 search_constant_strings > /git/arm-soc/scripts/gcc-plugins/initify_plugin.c:1367 > 0x7fe5cd712abe search_constant_strings > /git/arm-soc/scripts/gcc-plugins/initify_plugin.c:1506 Two more ICEs: a) *** WARNING *** there are active plugins, do not report this as a bug unless you can reproduce it without enabling any plugins. Event | Plugins PLUGIN_ATTRIBUTES | latent_entropy_plugin initify_plugin PLUGIN_START_UNIT | latent_entropy_plugin initify_plugin /git/arm-soc/drivers/scsi/gdth.c: In function 'gdth_search_drives': /git/arm-soc/drivers/scsi/gdth.c:1550:12: internal compiler error: in search_constant_strings, at git/arm-soc/scripts/gcc-plugins/initify_plugin.c:1375 static int gdth_search_drives(gdth_ha_str *ha) ^~~~~~~~~~~~~~~~~~ 0x2b0f7a831b9d search_constant_strings /git/arm-soc/scripts/gcc-plugins/initify_plugin.c:1375 0x2b0f7a831950 search_constant_strings /git/arm-soc/scripts/gcc-plugins/initify_plugin.c:1335 0x2b0f7a831950 search_constant_strings /git/arm-soc/scripts/gcc-plugins/initify_plugin.c:1367 0x2b0f7a832abe search_constant_strings /git/arm-soc/scripts/gcc-plugins/initify_plugin.c:1506 0x2b0f7a832abe search_var_param /git/arm-soc/scripts/gcc-plugins/initify_plugin.c:1419 0x2b0f7a832abe search_const_strs /git/arm-soc/scripts/gcc-plugins/initify_plugin.c:1471 0x2b0f7a832abe initify_function_transform /git/arm-soc/scripts/gcc-plugins/initify_plugin.c:1519 0x9b6c07 execute_one_ipa_transform_pass /home/arnd/git/gcc/gcc/passes.c:2207 0x9b6c07 execute_all_ipa_transforms() /home/arnd/git/gcc/gcc/passes.c:2249 0x734d6c cgraph_node::expand() /home/arnd/git/gcc/gcc/cgraphunit.c:2031 0x7362cc expand_all_functions /home/arnd/git/gcc/gcc/cgraphunit.c:2174 0x7362cc symbol_table::compile() /home/arnd/git/gcc/gcc/cgraphunit.c:2531 0x737d27 symbol_table::compile() /home/arnd/git/gcc/gcc/cgraphunit.c:2595 0x737d27 symbol_table::finalize_compilation_unit() /home/arnd/git/gcc/gcc/cgraphunit.c:2621 Please submit a full bug report, with preprocessed source if appropriate. This is the probably the same bug as the first, and I've worked around it incorrectly for now: diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c index d020a13646ae..37c9cf7a4e82 100644 --- a/drivers/scsi/gdth.c +++ b/drivers/scsi/gdth.c @@ -3846,6 +3846,8 @@ static const char *gdth_ctr_name(gdth_ha_str *ha) { TRACE2(("gdth_ctr_name()\n")); + return ""; + if (ha->type == GDT_EISA) { switch (ha->stype) { case GDT3_ID: b) *** WARNING *** there are active plugins, do not report this as a bug unless you can reproduce it without enabling any plugins. Event | Plugins PLUGIN_ATTRIBUTES | initify_plugin PLUGIN_START_UNIT | initify_plugin /git/arm-soc/arch/x86/kernel/traps.c:1049:1: internal compiler error: in set_section, at symtab.c:1514 } ^ 0x724dd6 symtab_node::set_section(char const*) /home/arnd/git/gcc/gcc/symtab.c:1514 0x2b26ed538c51 move_function_to_init_exit_text /git/arm-soc/scripts/gcc-plugins/initify_plugin.c:1751 0x2b26ed538c51 initify_execute /git/arm-soc/scripts/gcc-plugins/initify_plugin.c:1771 0x2b26ed538c51 execute /git/arm-soc/scripts/gcc-plugins/gcc-generate-ipa-pass.h:215 Please submit a full bug report, This one is different from the other two, and I don't know much about what happened, but this clearly bogus change avoids the problem: diff --git a/arch/x86/include/asm/desc.h b/arch/x86/include/asm/desc.h index d0a21b12dd58..3793900f7f73 100644 --- a/arch/x86/include/asm/desc.h +++ b/arch/x86/include/asm/desc.h @@ -508,7 +508,7 @@ static inline void alloc_system_vector(int vector) */ static inline void set_system_intr_gate(unsigned int n, void *addr) { - BUG_ON((unsigned)n > 0xFF); + //BUG_ON((unsigned)n > 0xFF); _set_gate(n, GATE_INTERRUPT, addr, 0x3, 0, __KERNEL_CS); } Aside from these problems and the annotations I sent yesterday, the initify plugin doesn't cause any more build-time regressions for me, so I'm leaving it enabled. Arnd