From: Arnd Bergmann <arnd@arndb.de>
To: michel@daenzer.net
Cc: "Alex Deucher" <alexdeucher@gmail.com>,
"David (ChunMing) Zhou" <David1.Zhou@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
amd-gfx@lists.freedesktop.org, "Shirish S" <shirish.s@amd.com>,
Jerry.Zuo@amd.com, dri-devel <dri-devel@lists.freedesktop.org>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Harry Wentland" <Harry.Wentland@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH] [v3] drm: amd: dc: don't use FP math when Kcov is enabled
Date: Tue, 14 Aug 2018 11:15:38 +0200 [thread overview]
Message-ID: <CAK8P3a3fDOeNWsmtXRHOF5cAMit7AMt7fS_54m7NXN0AjZYbPw@mail.gmail.com> (raw)
In-Reply-To: <632dceb6-27e5-869b-46a9-6b11944204fc@daenzer.net>
On Tue, Aug 14, 2018 at 10:54 AM Michel Dänzer <michel@daenzer.net> wrote:
>
> On 2018-08-13 05:23 PM, Arnd Bergmann wrote:
> > On Mon, Aug 13, 2018 at 4:49 PM Alex Deucher <alexdeucher@gmail.com> wrote:
> >>
> >> On Sun, Aug 12, 2018 at 3:55 AM Christian König
> >> <ckoenig.leichtzumerken@gmail.com> wrote:
> >>> Adding Harry as well.
> >>> Am 11.08.2018 um 17:54 schrieb Arnd Bergmann:
> >>>>
> >>>> Fixes: bf2e2e2e0ea9 ("drm/amd/display: Limit DCN to x86 arch")
> >>>> Fixes: 4841203102a3 ("drm/amdgpu/display: Replace CONFIG_DRM_AMD_DC_DCN1_0 with CONFIG_X86")
> >>
> >> Maybe it would be better to revert 4841203102a3 so we can limit the
> >> scope of this to DCN support.
> >
> > That would help, but we would still require the patch at
> > https://patchwork.kernel.org/patch/10090227/ or something else to avoid
> > broken randconfig builds.
>
> FWIW, please don't revert 4841203102a3 in a way which allows
> CONFIG_DRM_AMD_DC_DCN1_0 to be accidentally disabled on X86 again. If it
> is reinstated, it should be strictly derived from other options, not
> changeable by the user.
How about making all of AMDGPU depend on
" !(KCOV_INSTRUMENT_ALL && KCOV_ENABLE_COMPARISONS) || BROKEN"
then?
Arnd
next prev parent reply other threads:[~2018-08-14 9:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-11 15:54 [PATCH] [v3] drm: amd: dc: don't use FP math when Kcov is enabled Arnd Bergmann
2018-08-12 7:55 ` Christian König
2018-08-13 14:48 ` Alex Deucher
2018-08-13 15:23 ` Arnd Bergmann
2018-08-14 8:54 ` Michel Dänzer
2018-08-14 9:15 ` Arnd Bergmann [this message]
2018-08-14 9:17 ` Christian König
2018-08-15 16:18 ` allmodconfig/allyesconfig doesn't work with Kernel 4.18 - Was: " Mauro Carvalho Chehab
2018-08-16 19:55 ` Leo Li
2018-08-16 21:01 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a3fDOeNWsmtXRHOF5cAMit7AMt7fS_54m7NXN0AjZYbPw@mail.gmail.com \
--to=arnd@arndb.de \
--cc=David1.Zhou@amd.com \
--cc=Harry.Wentland@amd.com \
--cc=Jerry.Zuo@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michel@daenzer.net \
--cc=shirish.s@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).