From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B72AAC4727D for ; Fri, 25 Sep 2020 11:26:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8491620715 for ; Fri, 25 Sep 2020 11:26:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728217AbgIYL0B (ORCPT ); Fri, 25 Sep 2020 07:26:01 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:45371 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726255AbgIYLZ6 (ORCPT ); Fri, 25 Sep 2020 07:25:58 -0400 Received: from mail-qk1-f179.google.com ([209.85.222.179]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MgRYd-1kwCLc1vFX-00hvjC; Fri, 25 Sep 2020 13:25:55 +0200 Received: by mail-qk1-f179.google.com with SMTP id c2so2336103qkf.10; Fri, 25 Sep 2020 04:25:55 -0700 (PDT) X-Gm-Message-State: AOAM5334jI9lUYdfqrX8c/lihGQjzVpaGFwoxlem6D/vZ2S3FuglYzFR 7yrp8bmhO5GM3o/uSMd7SjmDENLgJlU8scQMdtg= X-Google-Smtp-Source: ABdhPJwWQvaM6Vz+GqP/QiHN8MWCzHaGRxzRTsvYnBX59Ke/YE3u+ANi9IHrX2XXPEGJOp/WEQFkuy3Z7sPF8uMEWds= X-Received: by 2002:a05:620a:15a7:: with SMTP id f7mr3352274qkk.3.1601033154195; Fri, 25 Sep 2020 04:25:54 -0700 (PDT) MIME-Version: 1.0 References: <20200925072630.8157-1-sherry.sun@nxp.com> In-Reply-To: <20200925072630.8157-1-sherry.sun@nxp.com> From: Arnd Bergmann Date: Fri, 25 Sep 2020 13:25:38 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/5] Add noncoherent platform support for vop driver To: Sherry Sun Cc: Sudeep Dutt , Ashutosh Dixit , gregkh , wang.yi59@zte.com.cn, huang.zijiang@zte.com.cn, Rikard Falkeborn , Lee Jones , "Michael S. Tsirkin" , "linux-kernel@vger.kernel.org" , NXP Linux Team , linux-pci , Lorenzo Pieralisi , Kishon Vijay Abraham I , linux-ntb@googlegroups.com Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:A6CRrB5zADy/SfDsnagYcP4KiTRZHOWhi5jsw46kMTQLTD9LZoa miVJV6TDFMsKOBdW+oSqjGdw5Bxin/aZnpnbwg5Q83hbZsKtU+kk8qpoW1SAB+m7u5okmdu e3ppY2o/qiG+O1ee0d0fkDOdqBSwWHv2C7JQZI7mcQklaOZJHv1Xy+uaBixsFMP/cVDF06u pXTeAFTOHiv1NejEzwVog== X-UI-Out-Filterresults: notjunk:1;V03:K0:qejb5m8lqS8=:mMH7eS+fWs0JkVVhR0qGRf sT7Mc9xxLi0CnF3X8oh8qfaNL1FaZK64iZZLv51WHF1VuY0qPvStbjdSVqWP/GYZXrFgGq/OO vr/zXUs6reodSYicJNU/W8ZbgCfUmhBgMfuN2C/7dV+CPIGp3HmwSo5YZ+g+CAlG7JU5SCiu9 nMwqXRM8yNJBSSsSyyMsPw7EmFhlQTAw+iBbhjwRxdjAcbwOvdY95hYYQjOR52NLNcalniSgx BzLmxon65EhN5SCDXYiNlzgDZBEcnZ9MjeWFUXMxLHMILYh4U4P+qigQN6t6TwC9s1HArgDHL 8InZQN3DAO7pP+7C7aCuNNw7ft5gEky3UDxaNWrVfhKQYK4KvXh06t0crSYut476uABgurZFW URcafM0ylGHZBNrgJmj/8pEvrsM8Sa6E6PVNFmLHJ7Jkw/bHIPvCpqNfhgiS0K0X6oMvi5/67 P3LDkmTp+kuAXiPXGfkJxySVF9yCqVm+IMs/SYuou2E076bCDWkKbcnrlhihXWEx1SIamHHYM A2b/oe4qi4VLhPEB33xsOKfi+p9qoRuO5ItqOAacox8q69pd73xOJsQm/PHe2U2skOBrPmtxc bBkU5gUYkcB40LVAAPAdPUMCfoQkJA0v7942tf9AGvvAXcvgtrCaMjfVl2dpdueM2E/78GREB vSQtQ9PYNSGH+t3aIn+arkiIBfeYKphsNxK/KmYq9rFOuJ5wSl084C5rCpTalyY2ievW513kT Pvu74Ix3vurWYDPUtWmtG3M+XV3yMeSKfXBar0HtCDzWJbSM7hh1PqIsQEzg8RxQyOREqdIOU xHQnR/YLzGNN9cIrCzMPnaYZqwsw3jbj0tNb6bWh1gmCassMEaQTjXNond3zrMELqCWBYbvEj HxNKkIBtspuD/4mvMEpMsiaIB7Jx2PBP3D6CYPAxWPRBvOcLLu4rqpf/glYpFCgVImf57P0Oo eVJQSoyqDNjfrfaLuFweTr4eoeznWCPA062nq8KOXQBCJ2h4x+LXX Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 25, 2020 at 9:27 AM Sherry Sun wrote: > > Change the way of allocating vring to support noncoherent platform for vop > driver, and add some related dma changes to make sure noncoherent platform works > well. Could you describe why you are doing this? Are you using Intel MIC devices on Arm hosts, or trying to reuse the code for other add-on cards? Note that we have a couple of frameworks in the kernel that try to do some of the same things here, notably the NTB drivers and the PCI endpoint support, both of which are designed to be somewhat more generic than the MIC driver. Have you considered using that instead? Arnd > Sherry Sun (5): > misc: vop: change the way of allocating vring for noncoherent platform > misc: vop: change the way of allocating used ring > misc: vop: simply return the saved dma address instead of virt_to_phys > misc: vop: set VIRTIO_F_ACCESS_PLATFORM for nocoherent platform > misc: vop: mapping kernel memory to user space as noncached > > drivers/misc/mic/bus/vop_bus.h | 2 + > drivers/misc/mic/host/mic_boot.c | 8 ++ > drivers/misc/mic/vop/vop_main.c | 51 +++++++++---- > drivers/misc/mic/vop/vop_vringh.c | 117 ++++++++++++++++++++---------- > 4 files changed, 125 insertions(+), 53 deletions(-) > > -- > 2.17.1 >