From: Arnd Bergmann <arnd@arndb.de>
To: John Garry <john.garry@huawei.com>
Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Xiang Chen <chenxiang66@hisilicon.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linuxarm <linuxarm@huawei.com>,
Shiju Jose <shiju.jose@huawei.com>
Subject: Re: [PATCH] scsi: hisi_sas: select CONFIG_RAS
Date: Fri, 3 Nov 2017 11:19:50 +0100 [thread overview]
Message-ID: <CAK8P3a3fvRQ+oUg=EUuWxdyyyMGHiL7sQMLhCY53sfCRyinOAA@mail.gmail.com> (raw)
In-Reply-To: <bdb263f7-7e1f-47ab-881b-2feeeeccfbf5@huawei.com>
On Fri, Nov 3, 2017 at 11:14 AM, John Garry <john.garry@huawei.com> wrote:
> + Shiju, who authored the original patch
>
>> index d42f29a5eb65..6ad8a6251d21 100644
>> --- a/drivers/scsi/hisi_sas/Kconfig
>> +++ b/drivers/scsi/hisi_sas/Kconfig
>> @@ -4,6 +4,7 @@ config SCSI_HISI_SAS
>> depends on ARM64 || COMPILE_TEST
>> select SCSI_SAS_LIBSAS
>> select BLK_DEV_INTEGRITY
>> + select RAS
>
>
> My impression is that we don't want this. Correction: shouldn't want this.
>
> Do you have the .config for the broken build? I couldn't recreate this by
> turning off CONFIG_RAS.
Uploaded to https://pastebin.com/A1rJYhDr
Maybe you were missing support for tracing in your configuration?
Arnd
next prev parent reply other threads:[~2017-11-03 10:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 16:50 [PATCH] scsi: hisi_sas: select CONFIG_RAS Arnd Bergmann
2017-11-03 10:14 ` John Garry
2017-11-03 10:19 ` Arnd Bergmann [this message]
2017-11-03 12:02 ` John Garry
2017-11-03 15:24 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a3fvRQ+oUg=EUuWxdyyyMGHiL7sQMLhCY53sfCRyinOAA@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=chenxiang66@hisilicon.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=shiju.jose@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).