From: Arnd Bergmann <firstname.lastname@example.org> To: Karol Herbst <email@example.com> Cc: Linux Kernel Mailing List <firstname.lastname@example.org>, Lyude Paul <email@example.com>, Ben Skeggs <firstname.lastname@example.org>, Randy Dunlap <email@example.com>, Daniel Vetter <firstname.lastname@example.org>, ML nouveau <email@example.com>, dri-devel <firstname.lastname@example.org> Subject: Re: [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices Date: Wed, 4 Aug 2021 23:09:51 +0200 [thread overview] Message-ID: <CAK8P3a3hZ7X5+kM5E+_Y+COUp49Kt6iDjiqMFtimiSbPk4byzQ@mail.gmail.com> (raw) In-Reply-To: <CACO55tuy5Am9zbcR490KWYYAg7MguBN5m82vbjzifGN5KpGbxw@mail.gmail.com> On Wed, Aug 4, 2021 at 8:59 PM Karol Herbst <email@example.com> wrote: > On Wed, Aug 4, 2021 at 4:43 PM Karol Herbst <firstname.lastname@example.org> wrote: > > On Wed, Aug 4, 2021 at 4:19 PM Arnd Bergmann <email@example.com> wrote: > > > On Wed, Aug 4, 2021 at 4:10 PM Karol Herbst <firstname.lastname@example.org> wrote: > > > > > > > > playing around a little bit with this, I think the original "select > > > > BACKLIGHT_CLASS_DEVICE" is fine. Atm we kind of have this weird mix of > > > > drivers selecting and others depending on it. We could of course convert > > > > everything over to depend, and break those cycling dependency issues with > > > > this. > > > > > > > > Anyway this change on top of my initial patch is enough to make Kconfig > > > > happy and has the advantage of not having to mess with the deps of nouveau > > > > too much. > > > > > > Looks good to me. We'd probably want to make the BACKLIGHT_CLASS_DEVICE > > > option itself 'default FB || DRM' though, to ensure that defconfigs > > > keep working. > > > > > > > okay cool. Will send out a proper updated patch series soonish. > > > > mhh, actually that breaks drivers selecting FB_BACKLIGHT as now > BACKLIGHT_CLASS_DEVICE might be disabled :( Are you sure? It should already be the case that any driver that selects FB_BACKLIGHT either 'depends on BACKLIGHT_CLASS_DEVICE' or 'select BACKLIGHT_CLASS_DEVICE'. If you change all the 'select BACKLIGHT_CLASS_DEVICE' to 'depends on', I don't see a problem with doing 'select FB_BACKLIGHT' from those. I have applied your patch to my randconfig tree and built a few dozen kernels, don't see any regressions so far, but will let it run over night. Arnd
next prev parent reply other threads:[~2021-08-04 21:10 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-23 22:46 [PATCH] nouveau: make backlight support non optional Karol Herbst 2021-07-24 6:55 ` Arnd Bergmann 2021-07-24 9:54 ` Karol Herbst 2021-07-24 11:56 ` Arnd Bergmann 2021-07-24 12:10 ` Karol Herbst 2021-07-24 12:51 ` Karol Herbst 2021-07-24 14:04 ` Arnd Bergmann 2021-07-24 14:13 ` Karol Herbst 2021-07-24 14:58 ` Arnd Bergmann 2021-08-04 14:10 ` [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices Karol Herbst 2021-08-04 14:19 ` Arnd Bergmann 2021-08-04 14:43 ` Karol Herbst 2021-08-04 18:59 ` Karol Herbst 2021-08-04 21:09 ` Arnd Bergmann [this message] 2021-08-04 22:01 ` Karol Herbst 2021-08-05 6:50 ` Arnd Bergmann 2021-08-09 13:20 ` [PATCH] nouveau: make backlight support non optional Jani Nikula 2021-08-09 13:30 ` Arnd Bergmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAK8P3a3hZ7X5+kM5E+_Y+COUp49Kt6iDjiqMFtimiSbPk4byzQ@mail.gmail.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] depend on BACKLIGHT_CLASS_DEVICE for more devices' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).