From: Arnd Bergmann <arnd@arndb.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Randy Dunlap <rdunlap@infradead.org>,
kernel test robot <lkp@intel.com>, Arnd Bergmann <arnd@arndb.de>,
kbuild-all@lists.01.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Greg Ungerer <gerg@linux-m68k.org>
Subject: Re: sound/isa/es1688/es1688_lib.c:384:79: error: 'DMA_AUTOINIT' undeclared
Date: Mon, 13 Sep 2021 15:51:26 +0200 [thread overview]
Message-ID: <CAK8P3a3mMH8s3tzeUhO4Z22-YYzRv5mExj=yY9hBwkGoMriSpg@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdWaoXOxC=wqUfC-9UTN+0QedGLqvZCr3rJjYmM2K9SZHQ@mail.gmail.com>
On Mon, Sep 13, 2021 at 9:55 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> > CONFIG_ISA_DMA_API=y
> > but CONFIG_ISA is not set.
> > (Yes, this is ColdFire.)
> >
> > menuconfig SND_ISA
> > bool "ISA sound devices"
> > depends on ISA || COMPILE_TEST
> > depends on ISA_DMA_API
> > default y
> >
> > I suppose that we could drop the "|| COMPILE_TEST" part.
>
> Or "... || (COMPILE_TEST && !M68K)"?
I think both approaches still fail for Q40 and AMIGA_PCMCIA,
which also set CONFIG_ISA, but still don't provide that
symbol.
AFAICT, we instead need
depends on ISA_DMA_API && !M68K
The COMPILE_TEST can stay then, though it would
not be a huge loss to remove that.
Arnd
prev parent reply other threads:[~2021-09-13 13:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 22:56 sound/isa/es1688/es1688_lib.c:384:79: error: 'DMA_AUTOINIT' undeclared kernel test robot
2021-09-11 2:32 ` Randy Dunlap
2021-09-13 7:54 ` Geert Uytterhoeven
2021-09-13 13:51 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a3mMH8s3tzeUhO4Z22-YYzRv5mExj=yY9hBwkGoMriSpg@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).