From: Arnd Bergmann <arnd@arndb.de>
To: "Loh, Tien Hock" <tien.hock.loh@intel.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Nguyen, Dinh" <dinh.nguyen@intel.com>,
"thloh85@gmail.com" <thloh85@gmail.com>,
"Gerlach, Matthew" <matthew.gerlach@intel.com>
Subject: Re: [PATCH 1/1] drivers/misc: Add Intel System ID driver
Date: Thu, 23 Feb 2017 09:05:43 +0100 [thread overview]
Message-ID: <CAK8P3a3n57ST2G8vXR8tzMrhLb7Fut6xUw3aNQEi-wi=hum8LQ@mail.gmail.com> (raw)
In-Reply-To: <1487829507.2961.5.camel@intel.com>
On Thu, Feb 23, 2017 at 6:58 AM, Loh, Tien Hock <tien.hock.loh@intel.com> wrote:
> On Rab, 2017-02-15 at 20:51 +0100, Arnd Bergmann wrote:
>> On Wed, Feb 15, 2017 at 6:17 PM, Greg KH <gregkh@linuxfoundation.org>
>> wrote:
>> >
>> > On Wed, Feb 15, 2017 at 07:09:41PM +0800, thloh wrote:
>> > >
>> > > From: "Loh, Tien Hock" <tien.hock.loh@intel.com>
>> > >
>> > > This patch is to add Altera System ID driver.
>> > > User can obtain the system ID and timestamp of the system by
>> > > reading the sysfs entry.
>> > >
>> > > Usage:
>> > > cat /sys/bus/platform/devices/[addr].sysid/sysid/id
>> > > cat /sys/bus/platform/devices/[addr].sysid/sysid/timestamp
>> > If you add new sysfs attributes, you need to also add a
>> > Documentation/ABI/ description as well.
>>
>> Maybe we could pretend that this is for a SoC and use the standard
>> soc_device
>> attributes as well as moving the driver into drivers/soc/?> Sorry for the late reply.
>
> This driver can currently be used by ARM and Nios II, so moving it into
> drivers/soc might not be the best idea.
Why not? drivers/soc/ was specifically introduced for stuff that is used on
some SoC but across more than one architecture (otherwise it would be
in arch/foo/). This seems to fit perfectly.
Arnd
next prev parent reply other threads:[~2017-02-23 8:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1487156981-4550-1-git-send-email-user@thloh-VirtualBox>
2017-02-15 17:17 ` [PATCH 1/1] drivers/misc: Add Intel System ID driver Greg KH
2017-02-15 19:51 ` Arnd Bergmann
2017-02-23 5:58 ` Loh, Tien Hock
2017-02-23 8:05 ` Arnd Bergmann [this message]
2017-02-23 8:15 ` Loh, Tien Hock
2017-03-01 7:23 ` Loh, Tien Hock
2017-03-01 9:01 ` Arnd Bergmann
2017-03-01 10:42 ` Loh, Tien Hock
2017-03-01 11:34 ` Arnd Bergmann
2017-03-02 2:17 ` Loh, Tien Hock
2017-02-23 5:50 ` Loh, Tien Hock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a3n57ST2G8vXR8tzMrhLb7Fut6xUw3aNQEi-wi=hum8LQ@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=dinh.nguyen@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.gerlach@intel.com \
--cc=thloh85@gmail.com \
--cc=tien.hock.loh@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).