From: Arnd Bergmann <arnd@arndb.de>
To: Chanho Park <chanho61.park@samsung.com>
Cc: Arnd Bergmann <arnd@arndb.de>, John Stultz <jstultz@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Stephen Boyd <sboyd@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] linux/time32.h: correct ns_to_kernel_old_timeval prototype
Date: Tue, 31 May 2022 13:25:56 +0200 [thread overview]
Message-ID: <CAK8P3a3nknJgEDESGdJH91jMj6R_xydFqWASd8r5BbesdvMBgA@mail.gmail.com> (raw)
In-Reply-To: <20220531064346.51677-1-chanho61.park@samsung.com>
On Tue, May 31, 2022 at 8:43 AM Chanho Park <chanho61.park@samsung.com> wrote:
>
> The function argument is defined with const identifier in
> kernel/time/time.c but the prototype looks different between time.c and
> time32.h. There is a review[1] why it was omitted during review stage but
> they should be matched.
Thanks for report and the patch!
Since the 'const' keyword is still useless here, I would suggest
instead dropping
it from the function definition where I accidentally left it, and from the
related ns_to_timespec64() as well, both its declaration and definition.
Arnd
prev parent reply other threads:[~2022-05-31 11:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220531064348epcas2p2168f11ba49e9a119219bebe18a769dff@epcas2p2.samsung.com>
2022-05-31 6:43 ` [PATCH] linux/time32.h: correct ns_to_kernel_old_timeval prototype Chanho Park
2022-05-31 11:25 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a3nknJgEDESGdJH91jMj6R_xydFqWASd8r5BbesdvMBgA@mail.gmail.com \
--to=arnd@arndb.de \
--cc=chanho61.park@samsung.com \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).