From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1576506-1516272087-2-3871593639730122615 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, FREEMAIL_FORGED_FROMDOMAIN 0.25, FREEMAIL_FROM 0.001, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_NONE -0.0001, RCVD_IN_MSPIKE_H3 -0.01, RCVD_IN_MSPIKE_WL -0.01, SPF_PASS -0.001, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='74.125.82.194', Host='mail-ot0-f194.google.com', Country='US', FromHeader='de', MailFrom='com' X-Spam-charsets: plain='UTF-8' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: arndbergmann@gmail.com ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516272087; b=JQnZwq5ZM5Bo5ayauBNRjCOmtP8VbpzIc2OBEI7O642X3qy IGIKyRZkAxN8KdVN/quhmNiqtQQSqBqHIP+Qc5TsFWI3X33p1PnFWMzEhBPprAMw ixJ1mKt5MR7Aqf3Lf5FCWtegHBWTE4ZuShCnzmMF5yBqgNscMTRYtjS9aiTqAJbG P16n2VDt4L6iS7+MRcH3ht8qRaLz3LS2dKbr64Jj6eO9/XfqzIUaMEdokZBZcykn cSzLws8kmBvPWn5llNl4xYbi6IpuKYtc6bZnGFzdE32C1rxbMts46UAMaGmNrBkb GJGm06zx3XlrHW+mOeqYsNOiPm6p+l9aqE/GraQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=mime-version:sender:in-reply-to :references:from:date:message-id:subject:to:cc:content-type; s= arctest; t=1516272087; bh=bLaltIemH7pvr9sugMZDYHwhmSGcK3DViuk+7G s4L/M=; b=q0ySdANS+zIHWGzbT2J2EghaTRXk9nEHhmfKItgwCo0rqxVFVgeqsj RD6Xh0DmiXUQpQkdmlp7WFsOu7+JYaUEKRT1XcJN/O+pkIvwDTurb7YJwGXczD77 96RG7z4SgL1udQBGHQMt+ItSvgHCqWTZGpxfUkfavO1A1IGfdKaBFLQrasAqAbIN gmDbWxTaIdllsLgGjgntPbRpvK+6R0uy3MzHWtEnK4iKP7NEAtGcN0Ja2jfL5YaE si9GNwiWNMgSVbIqWY0Qo+Iq1naz4r4yBy22coosF5h6nqn/O5Ri7P4N0ImbcWFo agPtR4gN0s9p+sZc3WJ9M+lrutROWFPQ== ARC-Authentication-Results: i=1; mx5.messagingengine.com; arc=none (no signatures found); dkim=pass (2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=ATINU2dR x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=none (p=none,d=none) header.from=arndb.de; iprev=pass policy.iprev=74.125.82.194 (mail-ot0-f194.google.com); spf=pass smtp.mailfrom=arndbergmann@gmail.com smtp.helo=mail-ot0-f194.google.com; x-aligned-from=fail; x-google-dkim=pass (2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=nYuRKa+x; x-ptr=pass x-ptr-helo=mail-ot0-f194.google.com x-ptr-lookup=mail-ot0-f194.google.com; x-return-mx=pass smtp.domain=gmail.com smtp.result=pass smtp_is_org_domain=yes header.domain=arndb.de header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 Authentication-Results: mx5.messagingengine.com; arc=none (no signatures found); dkim=pass (2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=ATINU2dR x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=none (p=none,d=none) header.from=arndb.de; iprev=pass policy.iprev=74.125.82.194 (mail-ot0-f194.google.com); spf=pass smtp.mailfrom=arndbergmann@gmail.com smtp.helo=mail-ot0-f194.google.com; x-aligned-from=fail; x-google-dkim=pass (2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=nYuRKa+x; x-ptr=pass x-ptr-helo=mail-ot0-f194.google.com x-ptr-lookup=mail-ot0-f194.google.com; x-return-mx=pass smtp.domain=gmail.com smtp.result=pass smtp_is_org_domain=yes header.domain=arndb.de header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 X-Google-Smtp-Source: ACJfBos4vki+JTRRzYXcXi4Rvkycrm08A6EucMqj7fpZhkpgi4QiO/xo3HXgIyuwraxvHtm4VL/2V1Woq/YU6pVccsc= MIME-Version: 1.0 Sender: arndbergmann@gmail.com In-Reply-To: <0a0789a3f776a5248ebc01706d502a3a9823cfac.1515766253.git.green.hu@gmail.com> References: <0a0789a3f776a5248ebc01706d502a3a9823cfac.1515766253.git.green.hu@gmail.com> From: Arnd Bergmann Date: Thu, 18 Jan 2018 11:41:25 +0100 X-Google-Sender-Auth: vxuQGiCQI5BnUhM6B2FTKatp06g Message-ID: Subject: Re: [PATCH v6 24/36] nds32: Loadable modules To: Greentime Hu Cc: Greentime , Linux Kernel Mailing List , linux-arch , Thomas Gleixner , Jason Cooper , Marc Zyngier , Rob Herring , Networking , Vincent Chen , DTML , Al Viro , David Howells , Will Deacon , Daniel Lezcano , linux-serial@vger.kernel.org, Geert Uytterhoeven , Linus Walleij , Mark Rutland , Greg KH , Guo Ren , Randy Dunlap , David Miller , Jonas Bonn , Stefan Kristiansson , Stafford Horne , Vincent Chen Content-Type: text/plain; charset="UTF-8" X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu wrote: > From: Greentime Hu > > This patch adds support for loadable modules. One detail: You still seem to have both the ELF_REL and ELF_RELA based functions implemented here, you should drop the unused ELF_REL version: > diff --git a/arch/nds32/kernel/module.c b/arch/nds32/kernel/module.c > new file mode 100644 > index 0000000..714a6d6 > --- /dev/null > +++ b/arch/nds32/kernel/module.c > @@ -0,0 +1,286 @@ > +// SPDX-License-Identifier: GPL-2.0 > +// Copyright (C) 2005-2017 Andes Technology Corporation > + > +#include > +#include > +#include > + > +#include include to catch this. > +int > +apply_relocate(Elf32_Shdr * sechdrs, const char *strtab, > + unsigned int symindex, unsigned int relsec, > + struct module *module) > +{ > + return 0; > +} and drop this. With that change, Acked-by: Arnd Bergmann