linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@kernel.org>
To: kernel test robot <lkp@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	kbuild-all@lists.01.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Greg Ungerer <gerg@linux-m68k.org>
Subject: Re: arch/m68k/68000/dragen2.c:73:16: error: 'screen_bits' undeclared
Date: Fri, 12 Feb 2021 11:05:11 +0100	[thread overview]
Message-ID: <CAK8P3a3uM7rCbnJP9r2SFEjm0D7oy2YsXw7VcGzkg5tq7mQbag@mail.gmail.com> (raw)
In-Reply-To: <202102121331.d4C0ShlS-lkp@intel.com>

On Fri, Feb 12, 2021 at 6:48 AM kernel test robot <lkp@intel.com> wrote:
>
> FYI, the error/warning still remains.

>          |             ^~~~~~~~~~~~
>    arch/m68k/68000/dragen2.c: In function 'init_dragen2':
> >> arch/m68k/68000/dragen2.c:73:16: error: 'screen_bits' undeclared (first use in this function)
>       73 |  LSSA = (long) screen_bits;
>          |                ^~~~~~~~~~~
>    arch/m68k/68000/dragen2.c:73:16: note: each undeclared identifier is reported only once for each function it appears in

This problem existed before my patch, I just moved the line to another file.
To fix it, one needs to test on real hardware and figure out what is supposed
to go in there.

The bug was apparently introduced in linux-2.5.70 in this commit:

commit 2b1a7e97c8c2d6330a432cbcaf83a0ef5fab848e
Author: gerg <gerg>
Date:   Mon May 26 16:45:57 2003 +0000

    [PATCH] fix m68knommu DragonEngine2 target setup code

    Numerous fixes for the m68knommu DragonEngine2 setup code.

    It was out of date relative to more recent kernels.  Original patches
    from Georges Menie.

    BKrev: 3ed244c5dPVeFKP63b4kkeS_rEshag


      Arnd

  reply	other threads:[~2021-02-12 10:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-12  5:48 arch/m68k/68000/dragen2.c:73:16: error: 'screen_bits' undeclared kernel test robot
2021-02-12 10:05 ` Arnd Bergmann [this message]
2021-02-17  4:55   ` [SPAM?]Re: " Greg Ungerer
2021-02-17 11:42     ` Geert Uytterhoeven
2021-02-17 12:22       ` Greg Ungerer
  -- strict thread matches above, loose matches on Subject: below --
2021-06-11  2:02 kernel test robot
2021-06-08 14:01 kernel test robot
2021-06-10 14:44 ` Greg Ungerer
2021-04-25 12:40 kernel test robot
2021-04-21 10:00 kernel test robot
2021-03-28 19:14 kernel test robot
2021-03-20  6:45 kernel test robot
2021-02-11 13:46 kernel test robot
2020-12-29  2:18 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAK8P3a3uM7rCbnJP9r2SFEjm0D7oy2YsXw7VcGzkg5tq7mQbag@mail.gmail.com \
    --to=arnd@kernel.org \
    --cc=arnd@arndb.de \
    --cc=gerg@linux-m68k.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).