From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754468AbdIFNCs (ORCPT ); Wed, 6 Sep 2017 09:02:48 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:35130 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753969AbdIFNCq (ORCPT ); Wed, 6 Sep 2017 09:02:46 -0400 X-Google-Smtp-Source: ADKCNb4w2c4z1EgGVYPuwicgyABekH55QUKsh9K5tz/yWzogAYFX308hIP5LkArUPWq6nFCjBGQ8oy+Xx2z41E8+kvI= MIME-Version: 1.0 In-Reply-To: References: <20170905182326.15681-1-mwilck@suse.com> From: Arnd Bergmann Date: Wed, 6 Sep 2017 15:02:44 +0200 X-Google-Sender-Auth: GhaUQ4maupedk4Y7HRLH9l0Rluw Message-ID: Subject: Re: [PATCH] string.h: un-fortify memcpy_and_pad To: Martin Wilck Cc: Christoph Hellwig , Keith Busch , Sagi Grimberg , Johannes Thumshirn , Hannes Reinecke , linux-nvme@lists.infradead.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 5, 2017 at 9:26 PM, Arnd Bergmann wrote: > On Tue, Sep 5, 2017 at 8:23 PM, Martin Wilck wrote: >> The way I'd implemented the new helper memcpy_and_pad with >> __FORTIFY_INLINE caused compiler warnings for certain kernel >> configurations. >> >> This helper is only used in a single place at this time, and thus >> doesn't benefit much from fortification. So simplify the code >> by dropping fortification support for now. >> >> Fixes: 3c5fa8cd18f8 "string.h: add memcpy_and_pad()" >> Signed-off-by: Martin Wilck > > Looks good to me, > > Acked-by: Arnd Bergmann > > I've added this to my randconfig testing tree, if you don't hear anything > from me by tomorrow, you can assume that it caused no other failures. build-tested successfully. Tested-by: Arnd Bergmann