From: Arnd Bergmann <arnd@arndb.de>
To: Daniel Palmer <daniel@0x0f.com>
Cc: "Arnd Bergmann" <arnd@arndb.de>, "Bert Vermeulen" <bert@biot.com>,
"Russell King" <linux@armlinux.org.uk>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Anshuman Khandual" <anshuman.khandual@arm.com>,
"Marc Zyngier" <maz@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"John Crispin" <john@phrozen.org>,
"Ard Biesheuvel" <ardb@kernel.org>,
"YiFei Zhu" <yifeifz2@illinois.edu>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Mike Rapoport" <rppt@kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
DTML <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 4/5] ARM: Add basic support for Airoha EN7523 SoC
Date: Tue, 7 Sep 2021 17:22:19 +0200 [thread overview]
Message-ID: <CAK8P3a3xZjg-SFs-bjtOrWMi5H7Ou4eRGsUEmy4XQUXqej+M9A@mail.gmail.com> (raw)
In-Reply-To: <CAFr9PX=Oi-HJYUFBfJn4pHUSk=drf7otyx473hvq1UC5_gaTHQ@mail.gmail.com>
On Tue, Sep 7, 2021 at 4:32 PM Daniel Palmer <daniel@0x0f.com> wrote:
> On Tue, 7 Sept 2021 at 23:12, Arnd Bergmann <arnd@arndb.de> wrote:
>
> > > I think the broken memory controller is still there so somehow I'd
> > > need to get the heavy barrier to work in arm64. I haven't yet worked
> > > out if that's even possible.
> >I think I missed that part of the discussion, or I forgot about it already.
> >What is the issue you are referring to here?
>
> Sorry. I should have put a bit more context. This is for the SSD268G
> not the original target of this series. But a similar situation.
> The SSD268G (according to the decompiled device tree) is the same
> hardware as the MSTAR_V7 chips but with a Cortex A53 instead of the
> Cortex A7.
> So it probably has the same memory controller as the MSTAR_V7 stuff
> and that memory controller is not coherent so it needs the kernel to
> make sure memory requests are flushed out to memory before DMA
> happens[0]. For arm I fixed that with the heavy mb callback. With
> arm64 I have no idea how to fix that.
Ok, got it. I do remember the Mstar SoCs having this problem. My feeling
is that this should be possible to implement on arm64 as well using
an erratum fixup with a configuration option, and possibly dynamic patching
to avoid the worst effects when the workaround is built into the kernel
but not needed.
Whether this is acceptable or not is up to the arm64 architecture maintainers
of course.
Arnd
next prev parent reply other threads:[~2021-09-07 15:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 10:27 [PATCH v2 0/5] Add support for Airoha EN7523 SoC Bert Vermeulen
2021-09-07 10:27 ` [PATCH v2 1/5] dt-bindings: Add vendor prefix for Airoha Bert Vermeulen
2021-09-07 11:13 ` Krzysztof Kozlowski
2021-09-07 10:27 ` [PATCH v2 2/5] dt-bindings: arm: airoha: Add binding for EN7523 SoC and EVB Bert Vermeulen
2021-09-07 10:27 ` [PATCH v2 3/5] ARM: dts: Add basic support for Airoha EN7523 Bert Vermeulen
2021-09-07 10:27 ` [PATCH v2 4/5] ARM: Add basic support for Airoha EN7523 SoC Bert Vermeulen
2021-09-07 10:48 ` Daniel Palmer
2021-09-07 11:51 ` Arnd Bergmann
2021-09-07 12:27 ` Daniel Palmer
2021-09-07 14:11 ` Arnd Bergmann
2021-09-07 14:32 ` Daniel Palmer
2021-09-07 15:22 ` Arnd Bergmann [this message]
2021-09-07 10:27 ` [PATCH v2 5/5] ARM: multi_v7_defconfig: Add " Bert Vermeulen
2021-09-07 10:39 ` Dmitry Osipenko
2021-09-07 10:41 ` Bert Vermeulen
2021-09-07 11:03 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a3xZjg-SFs-bjtOrWMi5H7Ou4eRGsUEmy4XQUXqej+M9A@mail.gmail.com \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=ardb@kernel.org \
--cc=bert@biot.com \
--cc=daniel@0x0f.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=john@phrozen.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=rppt@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yifeifz2@illinois.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).