From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754225AbdLDNoo (ORCPT ); Mon, 4 Dec 2017 08:44:44 -0500 Received: from mail-oi0-f66.google.com ([209.85.218.66]:44400 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752540AbdLDNol (ORCPT ); Mon, 4 Dec 2017 08:44:41 -0500 X-Google-Smtp-Source: AGs4zMayR0fm5jQAdN7V3cU8yU2b2Qy9WpgYw2gj2zNrLSrCsWstbWWbyYoAUh6ottoqkrOMRCIAjqIyhUojCznUsG4= MIME-Version: 1.0 In-Reply-To: <20171204005545.23325-5-deepa.kernel@gmail.com> References: <20171204005545.23325-1-deepa.kernel@gmail.com> <20171204005545.23325-5-deepa.kernel@gmail.com> From: Arnd Bergmann Date: Mon, 4 Dec 2017 14:44:40 +0100 X-Google-Sender-Auth: bWBwSgmLG87TgJ_YzKwbNltz2CA Message-ID: Subject: Re: [PATCH v3 4/4] input: serio: Replace timeval by timespec64 To: Deepa Dinamani Cc: Dmitry Torokhov , "open list:HID CORE LAYER" , Linux Kernel Mailing List , y2038 Mailman List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 4, 2017 at 1:55 AM, Deepa Dinamani wrote: > struct timeval is not y2038 safe. > All references to timeval will be deleted from the > kernel to make it y2038 safe. > Replace its uses by y2038 safe struct timespec64. > > The timestamps changed here only keep track of delta > times. These timestamps are also internal to kernel. > Hence, monotonic times are sufficient here. > The unit of the delta times is also changed in certain > cases to nanoseconds rather than microseconds. This is > in line with timespec64 which keeps time in nanoseconds. > > Signed-off-by: Deepa Dinamani > Reviewed-by: Arnd Bergmann Hi Deepa, I forgot you also had these on your backlog. I submitted a different set of patches two weeks ago for the two HP drivers, originally by Pingbo Wen, based on a different approach. That version simplified the code in question a bit more by using jiffies, while your version is a little safer since it changes less. Both versions should be fine though, it's up to Dmitry which one he wants to pick up. Arnd