* [PATCH] microblaze: Fix unistd_32.h generation format
@ 2020-02-12 7:56 Michal Simek
2020-02-12 8:38 ` Arnd Bergmann
0 siblings, 1 reply; 5+ messages in thread
From: Michal Simek @ 2020-02-12 7:56 UTC (permalink / raw)
To: linux-kernel, monstr, michal.simek, git, Firoz Khan, arnd
Cc: Stefan Asserhall
Generated files are also checked by sparse that's why add newline
to remove sparse (C=1) warning:
./arch/microblaze/include/generated/uapi/asm/unistd_32.h:438:45:
warning: no newline at end of file
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Stefan Asserhall <stefan.asserhall@xilinx.com>
---
arch/microblaze/kernel/syscalls/syscallhdr.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/microblaze/kernel/syscalls/syscallhdr.sh b/arch/microblaze/kernel/syscalls/syscallhdr.sh
index 2e9062a926a3..4f4238433644 100644
--- a/arch/microblaze/kernel/syscalls/syscallhdr.sh
+++ b/arch/microblaze/kernel/syscalls/syscallhdr.sh
@@ -33,4 +33,5 @@ grep -E "^[0-9A-Fa-fXx]+[[:space:]]+${my_abis}" "$in" | sort -n | (
printf "#endif\n"
printf "\n"
printf "#endif /* %s */" "${fileguard}"
+ printf "\n"
) > "$out"
--
2.25.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] microblaze: Fix unistd_32.h generation format
2020-02-12 7:56 [PATCH] microblaze: Fix unistd_32.h generation format Michal Simek
@ 2020-02-12 8:38 ` Arnd Bergmann
2020-02-12 8:42 ` Michal Simek
0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2020-02-12 8:38 UTC (permalink / raw)
To: Michal Simek
Cc: linux-kernel, Michal Simek, git, Firoz Khan, Stefan Asserhall
On Wed, Feb 12, 2020 at 8:56 AM Michal Simek <michal.simek@xilinx.com> wrote:
>
> Generated files are also checked by sparse that's why add newline
> to remove sparse (C=1) warning:
> ./arch/microblaze/include/generated/uapi/asm/unistd_32.h:438:45:
> warning: no newline at end of file
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> Reviewed-by: Stefan Asserhall <stefan.asserhall@xilinx.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
The patch looks good, but if you don't mind respinning it, could respin
it to do the same thing for all architectures at once? I see that some
already have it, but most don't.
> ---
>
> arch/microblaze/kernel/syscalls/syscallhdr.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/microblaze/kernel/syscalls/syscallhdr.sh b/arch/microblaze/kernel/syscalls/syscallhdr.sh
> index 2e9062a926a3..4f4238433644 100644
> --- a/arch/microblaze/kernel/syscalls/syscallhdr.sh
> +++ b/arch/microblaze/kernel/syscalls/syscallhdr.sh
> @@ -33,4 +33,5 @@ grep -E "^[0-9A-Fa-fXx]+[[:space:]]+${my_abis}" "$in" | sort -n | (
> printf "#endif\n"
> printf "\n"
> printf "#endif /* %s */" "${fileguard}"
> + printf "\n"
> ) > "$out"
> --
> 2.25.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] microblaze: Fix unistd_32.h generation format
2020-02-12 8:38 ` Arnd Bergmann
@ 2020-02-12 8:42 ` Michal Simek
2020-02-12 8:45 ` Arnd Bergmann
0 siblings, 1 reply; 5+ messages in thread
From: Michal Simek @ 2020-02-12 8:42 UTC (permalink / raw)
To: Arnd Bergmann, Michal Simek
Cc: linux-kernel, Michal Simek, git, Firoz Khan, Stefan Asserhall
On 12. 02. 20 9:38, Arnd Bergmann wrote:
> On Wed, Feb 12, 2020 at 8:56 AM Michal Simek <michal.simek@xilinx.com> wrote:
>>
>> Generated files are also checked by sparse that's why add newline
>> to remove sparse (C=1) warning:
>> ./arch/microblaze/include/generated/uapi/asm/unistd_32.h:438:45:
>> warning: no newline at end of file
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> Reviewed-by: Stefan Asserhall <stefan.asserhall@xilinx.com>
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> The patch looks good, but if you don't mind respinning it, could respin
> it to do the same thing for all architectures at once? I see that some
> already have it, but most don't.
I have not a problem to do so. I expect that this can be taken via your
tree that I can create only one patch. If this should go via
architectures tree would be better to create separate one.
Thanks,
Michal
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] microblaze: Fix unistd_32.h generation format
2020-02-12 8:42 ` Michal Simek
@ 2020-02-12 8:45 ` Arnd Bergmann
2020-02-12 9:17 ` Michal Simek
0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2020-02-12 8:45 UTC (permalink / raw)
To: Michal Simek
Cc: linux-kernel, Michal Simek, git, Firoz Khan, Stefan Asserhall
On Wed, Feb 12, 2020 at 9:42 AM Michal Simek <michal.simek@xilinx.com> wrote:
>
> On 12. 02. 20 9:38, Arnd Bergmann wrote:
> > On Wed, Feb 12, 2020 at 8:56 AM Michal Simek <michal.simek@xilinx.com> wrote:
> >>
> >> Generated files are also checked by sparse that's why add newline
> >> to remove sparse (C=1) warning:
> >> ./arch/microblaze/include/generated/uapi/asm/unistd_32.h:438:45:
> >> warning: no newline at end of file
> >>
> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> >> Reviewed-by: Stefan Asserhall <stefan.asserhall@xilinx.com>
> >
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
> >
> > The patch looks good, but if you don't mind respinning it, could respin
> > it to do the same thing for all architectures at once? I see that some
> > already have it, but most don't.
>
> I have not a problem to do so. I expect that this can be taken via your
> tree that I can create only one patch. If this should go via
> architectures tree would be better to create separate one.
Yes, I can take that into the asm-generic tree, or maybe you can just send it
to Andrew Morton.
Arnd
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] microblaze: Fix unistd_32.h generation format
2020-02-12 8:45 ` Arnd Bergmann
@ 2020-02-12 9:17 ` Michal Simek
0 siblings, 0 replies; 5+ messages in thread
From: Michal Simek @ 2020-02-12 9:17 UTC (permalink / raw)
To: Arnd Bergmann, Michal Simek
Cc: linux-kernel, Michal Simek, git, Firoz Khan, Stefan Asserhall
On 12. 02. 20 9:45, Arnd Bergmann wrote:
> On Wed, Feb 12, 2020 at 9:42 AM Michal Simek <michal.simek@xilinx.com> wrote:
>>
>> On 12. 02. 20 9:38, Arnd Bergmann wrote:
>>> On Wed, Feb 12, 2020 at 8:56 AM Michal Simek <michal.simek@xilinx.com> wrote:
>>>>
>>>> Generated files are also checked by sparse that's why add newline
>>>> to remove sparse (C=1) warning:
>>>> ./arch/microblaze/include/generated/uapi/asm/unistd_32.h:438:45:
>>>> warning: no newline at end of file
>>>>
>>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>>>> Reviewed-by: Stefan Asserhall <stefan.asserhall@xilinx.com>
>>>
>>> Acked-by: Arnd Bergmann <arnd@arndb.de>
>>>
>>> The patch looks good, but if you don't mind respinning it, could respin
>>> it to do the same thing for all architectures at once? I see that some
>>> already have it, but most don't.
>>
>> I have not a problem to do so. I expect that this can be taken via your
>> tree that I can create only one patch. If this should go via
>> architectures tree would be better to create separate one.
>
> Yes, I can take that into the asm-generic tree, or maybe you can just send it
> to Andrew Morton.
v2 sent.
M
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-02-12 9:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-12 7:56 [PATCH] microblaze: Fix unistd_32.h generation format Michal Simek
2020-02-12 8:38 ` Arnd Bergmann
2020-02-12 8:42 ` Michal Simek
2020-02-12 8:45 ` Arnd Bergmann
2020-02-12 9:17 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).