From: Arnd Bergmann <arnd@arndb.de>
To: Jeremy Kerr <jk@ozlabs.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
"Eric W . Biederman" <ebiederm@xmission.com>,
Andrew Morton <akpm@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@lst.de>,
Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] powerpc/spufs: fix copy_to_user while atomic
Date: Tue, 28 Apr 2020 18:00:27 +0200 [thread overview]
Message-ID: <CAK8P3a3ytp2eLa8sfC0se5fR-DFxMjqEh8_Y2N4PeH-yo1nhxw@mail.gmail.com> (raw)
In-Reply-To: <20200428120207.15728-1-jk@ozlabs.org>
On Tue, Apr 28, 2020 at 2:05 PM Jeremy Kerr <jk@ozlabs.org> wrote:
>
> Currently, we may perform a copy_to_user (through
> simple_read_from_buffer()) while holding a context's register_lock,
> while accessing the context save area.
>
> This change uses a temporary buffers for the context save area data,
> which we then pass to simple_read_from_buffer.
>
> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
> ---
Thanks for fixing this!
I wonder how far it should be backported, given that this has been broken for
14 years now.
Fixes: bf1ab978be23 ("[POWERPC] coredump: Add SPU elf notes to coredump.")
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2020-04-28 16:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 20:06 remove set_fs calls from the coredump code v4 Christoph Hellwig
2020-04-27 20:06 ` [PATCH 1/5] powerpc/spufs: simplify spufs core dumping Christoph Hellwig
2020-04-27 20:49 ` Al Viro
2020-04-28 2:51 ` Jeremy Kerr
2020-04-28 6:57 ` Christoph Hellwig
2020-04-28 12:02 ` [RFC PATCH] powerpc/spufs: fix copy_to_user while atomic Jeremy Kerr
2020-04-28 13:54 ` Christoph Hellwig
2020-04-28 16:00 ` Arnd Bergmann [this message]
2020-04-28 17:11 ` Christoph Hellwig
2020-04-29 1:36 ` Jeremy Kerr
2020-04-29 6:05 ` Christoph Hellwig
2020-04-29 6:13 ` Christoph Hellwig
2020-04-29 6:15 ` Christoph Hellwig
2020-04-29 6:33 ` Jeremy Kerr
2020-04-29 7:42 ` Arnd Bergmann
2020-04-27 20:06 ` [PATCH 2/5] signal: factor copy_siginfo_to_external32 from copy_siginfo_to_user32 Christoph Hellwig
2020-04-27 20:06 ` [PATCH 3/5] binfmt_elf: remove the set_fs in fill_siginfo_note Christoph Hellwig
2020-04-27 20:06 ` [PATCH 4/5] binfmt_elf: remove the set_fs(KERNEL_DS) in elf_core_dump Christoph Hellwig
2020-04-27 20:06 ` [PATCH 5/5] binfmt_elf_fdpic: remove the set_fs(KERNEL_DS) in elf_fdpic_core_dump Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a3ytp2eLa8sfC0se5fR-DFxMjqEh8_Y2N4PeH-yo1nhxw@mail.gmail.com \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=hch@lst.de \
--cc=jk@ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).