From: Sinan Kaya <Okaya@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
ACPI Devel Mailing List <linux-acpi@vger.kernel.org>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Jie Yang <yang.jie@linux.intel.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
"moderated list:INTEL ASoC DRIVERS" <alsa-devel@alsa-project.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 08/11] ASoC: Intel: Make PCI dependency explicit
Date: Sat, 22 Dec 2018 07:26:30 +0100 [thread overview]
Message-ID: <CAK9iUCN77U5tQn-WWaL27v244GkEAgRBxKK1H_+xUhOZ2aCERw@mail.gmail.com> (raw)
In-Reply-To: <eb27ab03-4f42-2e2e-9873-16d9a6927e2b@infradead.org>
On Sat, Dec 22, 2018 at 4:19 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 12/21/18 4:14 PM, Sinan Kaya wrote:
> > IOSF_MBI driver depends on CONFIG_PCI set but this is not specified
> > anywhere.
>
> wrong patch description...?
Not really...
Code does unconditional select for IOSF_MBI.
>
> > Signed-off-by: Sinan Kaya <okaya@kernel.org>
> > ---
> > sound/soc/intel/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
> > index 2fd1b61e8331..b0764b2fe001 100644
> > --- a/sound/soc/intel/Kconfig
> > +++ b/sound/soc/intel/Kconfig
> > @@ -91,7 +91,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_PCI
> > config SND_SST_ATOM_HIFI2_PLATFORM_ACPI
> > tristate "ACPI HiFi2 (Baytrail, Cherrytrail) Platforms"
> > default ACPI
> > - depends on X86 && ACPI
> > + depends on X86 && ACPI && PCI
> > select SND_SST_IPC_ACPI
> > select SND_SST_ATOM_HIFI2_PLATFORM
> > select SND_SOC_ACPI_INTEL_MATCH
> >
>
>
> --
> ~Randy
next prev parent reply other threads:[~2018-12-22 17:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181222001452.7474-1-okaya@kernel.org>
2018-12-22 0:14 ` [PATCH v1 01/11] ACPI / LPSS: Add guards against CONFIG_PCI Sinan Kaya
2018-12-22 0:14 ` [PATCH v1 02/11] ata: make PCI dependency explicit for PATA_ACPI Sinan Kaya
2018-12-22 0:14 ` [PATCH v1 03/11] vga-switcheroo: make PCI dependency explicit Sinan Kaya
2018-12-22 7:51 ` Lukas Wunner
2018-12-22 0:14 ` [PATCH v1 04/11] platform/x86: " Sinan Kaya
2018-12-22 0:14 ` [PATCH v1 05/11] platform/x86: intel_pmc: Hide PCI specific pieces behind CONFIG_PCI Sinan Kaya
2018-12-22 0:14 ` [PATCH v1 06/11] platform/x86: apple-gmux: hide PCI specific code Sinan Kaya
2018-12-22 8:03 ` Lukas Wunner
2018-12-22 8:31 ` Sinan Kaya
[not found] ` <CAHp75VfTmWN4bTNPaTL2KYYUWARvix67ynx2cKGzhO3o-0VY=g@mail.gmail.com>
2018-12-25 13:33 ` Sinan Kaya
2018-12-22 0:14 ` [PATCH v1 07/11] drivers: thermal: Hide PCI driver when CONFIG_PCI is unset Sinan Kaya
2018-12-22 0:14 ` [PATCH v1 08/11] ASoC: Intel: Make PCI dependency explicit Sinan Kaya
2018-12-22 3:18 ` Randy Dunlap
2018-12-22 6:26 ` Sinan Kaya [this message]
2018-12-22 8:34 ` Sinan Kaya
2018-12-22 0:14 ` [PATCH v1 09/11] mmc: add PCI dependency into IOSF_MBI Sinan Kaya
2018-12-22 0:14 ` [PATCH v1 10/11] x86: select IOSF_MBI only when CONFIG_PCI is set Sinan Kaya
2018-12-22 0:14 ` [PATCH v1 11/11] drivers: thermal: Make PCI dependency explicit Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK9iUCN77U5tQn-WWaL27v244GkEAgRBxKK1H_+xUhOZ2aCERw@mail.gmail.com \
--to=okaya@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rdunlap@infradead.org \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).