From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92F6BC43387 for ; Thu, 3 Jan 2019 03:29:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5524D20896 for ; Thu, 3 Jan 2019 03:29:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546486148; bh=Jug9QSBgCxluRLcEXDHuyKV9gRbvhSZmRoeeWPwP5OA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=b+5SsrnlM13ds/U3iqIn0wqBARBsW/JAcR+4NGqKI0/wvSWoXA4RqDg4V7VciO+wb Wr9W0GlcyhEtwHa6SaLPcKEPc0iLaw7IhNNBd+9rtSYFkXPaAJOnILuyXiVxGfyDgM zr7Gt/QBud0tP/RjLzCZTMe1rHrzCl4g0acH68sA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728858AbfACD3H (ORCPT ); Wed, 2 Jan 2019 22:29:07 -0500 Received: from mail.kernel.org ([198.145.29.99]:58226 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727113AbfACD3H (ORCPT ); Wed, 2 Jan 2019 22:29:07 -0500 Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4C7CD2171F; Thu, 3 Jan 2019 03:29:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546486145; bh=Jug9QSBgCxluRLcEXDHuyKV9gRbvhSZmRoeeWPwP5OA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=AsKh+CQ8pxD/nI4TOakaR1P6jUftCo2oczKnXBzAYKPKTCFWnM+8Up+oTBbxJtG0x LM89vz0rDR7xge6o9lBE5Vx2CE2SREyuJetX/BCj9DF71EkMa2WQJ2AU97iQ4XQFf6 0rkt2NsNqROjLoszTrjitUirKno5z2qosJW0MYvk= Received: by mail-ot1-f48.google.com with SMTP id w25so28343629otm.13; Wed, 02 Jan 2019 19:29:05 -0800 (PST) X-Gm-Message-State: AJcUukcZCs/PuVtuk7TRunyppJET+4Hit5PsmpxrvN3vaHkY6846ET07 3q9e1zZ1jpTJa2ZOHtsEB07uIak6HP3Boxajj0A= X-Google-Smtp-Source: ALg8bN6kVQ5y/adP7ZFalWVDcOmwuKqZiYTQGE+y2HO40kXn7/GcF97pzZULK5ZP7pnwNG2uzy8YE5GuWQFPcdi/BfE= X-Received: by 2002:a9d:784a:: with SMTP id c10mr33212634otm.175.1546486144513; Wed, 02 Jan 2019 19:29:04 -0800 (PST) MIME-Version: 1.0 References: <20190102181038.4418-1-okaya@kernel.org> <20190102181038.4418-9-okaya@kernel.org> <57ed1d94-7f89-20e8-3289-7ef7efd18c20@linux.intel.com> <8c69f8d0-6a95-0011-ff87-8ac9236a992d@linux.intel.com> In-Reply-To: <8c69f8d0-6a95-0011-ff87-8ac9236a992d@linux.intel.com> From: Sinan Kaya Date: Thu, 3 Jan 2019 03:28:52 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [alsa-devel] [PATCH v5 08/11] ASoC: Intel: atom: Make PCI dependency explicit To: Pierre-Louis Bossart Cc: "moderated list:INTEL ASoC DRIVERS" , Mark Brown , Jie Yang , Takashi Iwai , open list , Liam Girdwood , ACPI Devel Mailing List , Linux Next Mailing List , Chandan Rajendra , tony.luck@intel.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +Tony On Wed, Jan 2, 2019 at 11:50 PM Pierre-Louis Bossart wrote: > > > On 1/2/19 4:58 PM, Sinan Kaya wrote: > > On Wed, Jan 2, 2019 at 10:50 PM Pierre-Louis Bossart > > wrote: > >> > >>> This is pointing to a kconfig issue on ia64 arch. > >>> > >>> arch/ia64/Kconfig:128:error: recursive dependency detected! > >>> arch/ia64/Kconfig:128: choice contains symbol IA64_HP_SIM > >>> arch/ia64/Kconfig:202: symbol IA64_HP_SIM is part of choice PM > >>> > >>> IA64_HP_SIM is both a choice and is selected. > >>> > >>> I did allyesconfig and disabled PCI afterwards to find all the issues > >>> on this patchset. > >> Are you saying there's a newer series that fixes this issue for both > >> allyesconfig and allmodconfig? > >> > >> if yes, then we're good. > > > > No, I haven't fixed ia64 kconfig issue. That's somebody else's job. I > > used allyesconfig to find out all compilation issues on x86 arch to > > come up with this patchset. > > Nothing makes me cringe more than "somebody else's job" statements. In > this case, there is obviously a correlation with your ACPI changes since > the circular dependency happens because of the ACPI symbol. > I agree that it needs to be fixed. I am not convinced that the issue is related to my change. Your log is pointing to an inconsistency in ia64 kconfig. > arch/ia64/Kconfig:126:error: recursive dependency detected! > arch/ia64/Kconfig:126: choice contains symbol IA64_HP_SIM > arch/ia64/Kconfig:200: symbol IA64_HP_SIM is part of choice PM > kernel/power/Kconfig:144: symbol PM is selected by PM_SLEEP > kernel/power/Kconfig:104: symbol PM_SLEEP depends on HIBERNATE_CALLBACKS > kernel/power/Kconfig:31: symbol HIBERNATE_CALLBACKS is selected by > HIBERNATION > kernel/power/Kconfig:34: symbol HIBERNATION depends on SWAP > init/Kconfig:250: symbol SWAP depends on BLOCK > block/Kconfig:5: symbol BLOCK is selected by UBIFS_FS > fs/ubifs/Kconfig:1: symbol UBIFS_FS depends on MISC_FILESYSTEMS > fs/Kconfig:220: symbol MISC_FILESYSTEMS is selected by ACPI_APEI > drivers/acpi/apei/Kconfig:8: symbol ACPI_APEI depends on ACPI > drivers/acpi/Kconfig:9: symbol ACPI depends on ARCH_SUPPORTS_ACPI > <<<< LOOK HERE I am still having hard time seeing how this issue is exposed by removing PCI dependency from ACPi. Rafael, Tony: can you help me? > drivers/acpi/Kconfig:6: symbol ARCH_SUPPORTS_ACPI is selected by > IA64_HP_SIM > arch/ia64/Kconfig:200: symbol IA64_HP_SIM is part of choice > > At any rate, a 3 mn git bisect tells me the circular dependency is > exposed by this change: > > f3fd6cd74fedf99b6060f75df00943fda13b65f2 is the first bad commit > commit f3fd6cd74fedf99b6060f75df00943fda13b65f2 > Author: Chandan Rajendra > Date: Sat Dec 8 12:21:38 2018 +0530 > > fscrypt: remove filesystem specific build config option > > In order to have a common code base for fscrypt "post read" processing > for all filesystems which support encryption, this commit removes > filesystem specific build config option (e.g. > CONFIG_EXT4_FS_ENCRYPTION) > and replaces it with a build option (i.e. CONFIG_FS_ENCRYPTION) whose > value affects all the filesystems making use of fscrypt. > > Signed-off-by: Chandan Rajendra > Signed-off-by: Theodore Ts'o > > -Pierre > >