* [PATCH] dmaengine: qcom_hidma: Check for driver register failure
@ 2018-12-28 20:11 Aditya Pakki
2018-12-30 18:34 ` Sinan Kaya
2019-01-04 14:38 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Aditya Pakki @ 2018-12-28 20:11 UTC (permalink / raw)
To: pakki001
Cc: kjlu, Sinan Kaya, Andy Gross, David Brown, Vinod Koul,
Dan Williams, linux-arm-kernel, linux-arm-msm, dmaengine,
linux-kernel
While initializing the driver, the function platform_driver_register can
fail and return an error. Consistent with other invocations, this patch
returns the error upstream.
Signed-off-by: Aditya Pakki <pakki001@umn.edu>
---
drivers/dma/qcom/hidma_mgmt.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/dma/qcom/hidma_mgmt.c b/drivers/dma/qcom/hidma_mgmt.c
index d64edeb6771a..681de12f4c67 100644
--- a/drivers/dma/qcom/hidma_mgmt.c
+++ b/drivers/dma/qcom/hidma_mgmt.c
@@ -423,9 +423,8 @@ static int __init hidma_mgmt_init(void)
hidma_mgmt_of_populate_channels(child);
}
#endif
- platform_driver_register(&hidma_mgmt_driver);
+ return platform_driver_register(&hidma_mgmt_driver);
- return 0;
}
module_init(hidma_mgmt_init);
MODULE_LICENSE("GPL v2");
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: qcom_hidma: Check for driver register failure
2018-12-28 20:11 [PATCH] dmaengine: qcom_hidma: Check for driver register failure Aditya Pakki
@ 2018-12-30 18:34 ` Sinan Kaya
2019-01-04 14:38 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Sinan Kaya @ 2018-12-30 18:34 UTC (permalink / raw)
To: Aditya Pakki
Cc: kjlu, Andy Gross, David Brown, Vinod Koul, Dan Williams,
linux-arm-kernel, linux-arm-msm, dmaengine, open list
On Fri, Dec 28, 2018 at 11:11 PM Aditya Pakki <pakki001@umn.edu> wrote:
>
> While initializing the driver, the function platform_driver_register can
> fail and return an error. Consistent with other invocations, this patch
> returns the error upstream.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
> ---
Acked-by: Sinan Kaya <okaya@kernel.org>
> drivers/dma/qcom/hidma_mgmt.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dma/qcom/hidma_mgmt.c b/drivers/dma/qcom/hidma_mgmt.c
> index d64edeb6771a..681de12f4c67 100644
> --- a/drivers/dma/qcom/hidma_mgmt.c
> +++ b/drivers/dma/qcom/hidma_mgmt.c
> @@ -423,9 +423,8 @@ static int __init hidma_mgmt_init(void)
> hidma_mgmt_of_populate_channels(child);
> }
> #endif
> - platform_driver_register(&hidma_mgmt_driver);
> + return platform_driver_register(&hidma_mgmt_driver);
>
> - return 0;
> }
> module_init(hidma_mgmt_init);
> MODULE_LICENSE("GPL v2");
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dmaengine: qcom_hidma: Check for driver register failure
2018-12-28 20:11 [PATCH] dmaengine: qcom_hidma: Check for driver register failure Aditya Pakki
2018-12-30 18:34 ` Sinan Kaya
@ 2019-01-04 14:38 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2019-01-04 14:38 UTC (permalink / raw)
To: Aditya Pakki
Cc: kjlu, Sinan Kaya, Andy Gross, David Brown, Dan Williams,
linux-arm-kernel, linux-arm-msm, dmaengine, linux-kernel
On 28-12-18, 14:11, Aditya Pakki wrote:
> While initializing the driver, the function platform_driver_register can
> fail and return an error. Consistent with other invocations, this patch
> returns the error upstream.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-04 14:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-28 20:11 [PATCH] dmaengine: qcom_hidma: Check for driver register failure Aditya Pakki
2018-12-30 18:34 ` Sinan Kaya
2019-01-04 14:38 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).